From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C3DD43057A
	for <tarantool-patches@freelists.org>; Thu, 29 Nov 2018 11:14:40 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id qcNypdD8jiZA for <tarantool-patches@freelists.org>;
	Thu, 29 Nov 2018 11:14:40 -0500 (EST)
Received: from smtp18.mail.ru (smtp18.mail.ru [94.100.176.155])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3F7AB30576
	for <tarantool-patches@freelists.org>; Thu, 29 Nov 2018 11:14:40 -0500 (EST)
Subject: [tarantool-patches] Re: [PATCH v2 1/1] sql: fix parser.parse_only
 mode for triggers
References: <0943b4db119f16a30aad8198943568521508dfdb.1543507402.git.kshcherbatov@tarantool.org>
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Message-ID: <8a51d3d3-1e9b-752d-43ce-8a9c82222102@tarantool.org>
Date: Thu, 29 Nov 2018 19:14:38 +0300
MIME-Version: 1.0
In-Reply-To: <0943b4db119f16a30aad8198943568521508dfdb.1543507402.git.kshcherbatov@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>



On 29.11.2018 19:03, Kirill Shcherbatov wrote:
> The sql_trigger_compile routine had a Vdbe leak as parser doesn't
> releases VM(it is not required in typical scenario). As the
> parse_only flag had not worked correctly for sql triggers
> sql_trigger_compile have had a memory leak.
> 
> Closes #3838

    sql: fix parser.parse_only mode for triggers
    
    As the parse_only flag had not worked correctly for sql triggers
    sql_trigger_compile have had a Vdbe memory leak.
    
    Closes #3838