From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D1DEF469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 19 Mar 2020 13:24:23 +0300 (MSK)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
From: Serge Petrenko <sergepetrenko@tarantool.org>
In-Reply-To: <9ba81bc4-9ea3-65bd-41c2-924c1fb99881@tarantool.org>
Date: Thu, 19 Mar 2020 13:24:20 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <8DF201C0-3B24-4E49-85D5-86DB34A957CC@tarantool.org>
References: <c29d15e81d7df21df6bfa3f04bf58bcb987eee5f.1573596082.git.v.shpilevoy@tarantool.org>
 <27C6CB53-B660-4195-A09F-9B58EA089501@tarantool.org>
 <9ba81bc4-9ea3-65bd-41c2-924c1fb99881@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/1] iproto: show real port in logs
 and box.info.listen
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org


> 19 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2020 =D0=B3., =D0=B2 01:38, =
Vladislav Shpilevoy <v.shpilevoy@tarantool.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=
=81=D0=B0=D0=BB(=D0=B0):
>=20
> Thanks for the review!
>=20
> On 18/03/2020 19:18, Serge Petrenko wrote:
>> Hi! Thanks for the patch!
>> Alexander asked me to do the 2nd review.
>>=20
>> The patch LGTM.
>>=20
>> Sorry for nitpicking,  but looks like your changelog request has a =
typo in it:
>>> @ChangeLog
>>> - box.info.listen - new record in box.info <http://box.info>, which =
shows a
>>>  real port when bound to port 0. For example, if box.cfg
>>>  'listen' parameter was set to '127.0.0.1:0', box.info.listen
>>>  will show '127.0.0.1:<real port > 0>' (gh-4620).
>> just <real port>, without 0>, right?
>=20
> Nope, I meant > 0. I wanted to emphasize, that the port is never
> shown as 0 anymore. It is always some real port > 0.

Ah, I see. Sorry for the misunderstanding.

--
Serge Petrenko
sergepetrenko@tarantool.org