From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\))
Subject: Re: [tarantool-patches] Re: [PATCH v2 1/1] netbox: show is_nullable
 and collation fields
From: "v.shpilevoy@tarantool.org" <v.shpilevoy@tarantool.org>
In-Reply-To: <02f53c50-c3eb-9e8c-6d15-9adfb7d23c0d@tarantool.org>
Date: Mon, 26 Mar 2018 20:44:27 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <8B0870B9-34B3-4525-AF9C-702FB2410739@tarantool.org>
References: <cf039f93de4ddc5ae7d7d1578ec4c436d8a37d80.1522083375.git.kshcherbatov@tarantool.org>
 <82848BBB-2A50-4CAC-852E-E5EE5C8247A3@tarantool.org>
 <02f53c50-c3eb-9e8c-6d15-9adfb7d23c0d@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
List-ID: <tarantool-patches.dev.tarantool.org>

Looks good to me. Vova, please, take a look.

> 26 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2018 =D0=B3., =D0=B2 20:41, Kirill =
Shcherbatov <kshcherbatov@tarantool.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=
=B0=D0=BB(=D0=B0):
>=20
> diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua
> index fe45721..3b4ce05 100644
> --- a/test/box/net.box.test.lua
> +++ b/test/box/net.box.test.lua
> @@ -799,11 +799,9 @@ =
box.schema.user.revoke('guest','read,write,execute','universe')
>=20
>  space:drop()
>=20
> -
>  --
>  -- gh-3256 net.box is_nullable and collation options output
>  --
> -
>  space =3D box.schema.create_space('test')
>  box.schema.user.grant('guest','read,write,execute','space', 'test')
>  pk =3D space:create_index('pk')
> @@ -821,4 +819,5 @@ c =3D net:connect(box.cfg.listen)
>  c.space.test.index.sk.parts
>  c:close()
>  box.internal.collation.drop('test')
> -space:drop()
> \ No newline at end of file
> +space:drop()
> +
>=20
>=20
> On 26.03.2018 20:24, v.shpilevoy@tarantool.org wrote:
>> See below 2 minor comments.
>>=20
>>> 26 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2018 =D0=B3., =D0=B2 20:20, Kirill =
Shcherbatov <kshcherbatov@tarantool.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=
=B0=D0=BB(=D0=B0):
>>>=20
>>> Fixes #3256
>>> ---
>>>=20
>>> Issue: https://github.com/tarantool/tarantool/issues/3256
>>> Branch: =
https://github.com/tarantool/tarantool/compare/gh-3256-net-box-nullable-co=
llation-options-output
>>>=20
>>> src/box/lua/net_box.lua   |  6 ++++-
>>> test/box/net.box.result   | 65 =
+++++++++++++++++++++++++++++++++++++++++++++++
>>> test/box/net.box.test.lua | 24 +++++++++++++++++
>>> 3 files changed, 94 insertions(+), 1 deletion(-)
>>>=20
>>> diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua
>>> index c7541ed..fe45721 100644
>>> --- a/test/box/net.box.test.lua
>>> +++ b/test/box/net.box.test.lua
>>> @@ -798,3 +798,27 @@ c.space.test.index.test_index ~=3D nil
>>> box.schema.user.revoke('guest','read,write,execute','universe')
>>>=20
>>> space:drop()
>>> +
>>> +
>> 1. Please, do not put multiple empty lines, when it is not necessary.
>>=20
>>> +--
>>> +-- gh-3256 net.box is_nullable and collation options output
>>> +--
>>> +
>>> +space =3D box.schema.create_space('test')
>>> +box.schema.user.grant('guest','read,write,execute','space', 'test')
>>> +pk =3D space:create_index('pk')
>>> +sk =3D space:create_index('sk', {parts =3D {{2, 'unsigned', =
is_nullable =3D true}}})
>>> +c =3D net:connect(box.cfg.listen)
>>> +c.space.test.index.sk.parts
>>> +c:close()
>>> +space:drop()
>>> +
>>> +space =3D box.schema.create_space('test')
>>> +box.schema.user.grant('guest','read,write,execute','space', 'test')
>>> +box.internal.collation.create('test', 'ICU', 'ru-RU')
>>> +sk =3D space:create_index('sk', { type =3D 'tree', parts =3D {{1, =
'str', collation =3D 'test'}}, unique =3D true })
>>> +c =3D net:connect(box.cfg.listen)
>>> +c.space.test.index.sk.parts
>>> +c:close()
>>> +box.internal.collation.drop('test')
>>> +space:drop()
>>> \ No newline at end of file
>> 2. Please, add an empty line at the end of the file.
>>=20
>>> --=20
>>> 2.7.4
>>>=20
>>=20
>=20
>=20