From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 108972EB71
	for <tarantool-patches@freelists.org>; Tue, 30 Oct 2018 10:30:32 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 1g3jq14dXHeb for <tarantool-patches@freelists.org>;
	Tue, 30 Oct 2018 10:30:31 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C11102EB70
	for <tarantool-patches@freelists.org>; Tue, 30 Oct 2018 10:30:31 -0400 (EDT)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
Subject: [tarantool-patches] Re: [PATCH v8 3/3] sql: remove psql_txn from Vdbe
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <ce438a4888b055fa079996319d54dd57adc6eb97.1540832830.git.imeevma@gmail.com>
Date: Tue, 30 Oct 2018 17:30:29 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <8AB5D4C3-8319-4F19-9A69-68A8819C2B72@tarantool.org>
References: <cover.1540832830.git.imeevma@gmail.com>
 <ce438a4888b055fa079996319d54dd57adc6eb97.1540832830.git.imeevma@gmail.com>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>


> It makes no sense to store it here, and it has never
> did.

Nit: this sentence is grammatically incorrect, I guess.

> SQL transaction specific things shall be taken
> from global txn object, as any transaction specific
> things.
> ---
> Issue: https://github.com/tarantool/tarantool/issues/2618
> Branch: =
https://github.com/tarantool/tarantool/tree/imeevma/gh-2618-return-all-gen=
erated-ids
>=20

You don=E2=80=99t need to put links to branch/issue to each patch of =
patch-set -
you should do it only for covering letter.

Patch itself is OK, but I would either separate this patch from =
patch-set,
or add "Follow up #xxxx=E2=80=9D sign.