From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C17BF4696C3 for ; Fri, 17 Apr 2020 14:25:06 +0300 (MSK) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3594.4.19\)) From: Roman Khabibov In-Reply-To: <1c1301d61489$a1af1790$e50d46b0$@tarantool.org> Date: Fri, 17 Apr 2020 14:25:05 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <8A7E5353-3471-4B54-91F7-F35AB4A4B039@tarantool.org> References: <20200413041105.22576-1-roman.habibov@tarantool.org> <20200415194149.GA454@tarantool.org> <43EE02FF-1F00-4FBE-AC41-C8C58B390003@tarantool.org> <20200416081731.GA16144@tarantool.org> <6CC4ABB2-D49D-4721-B913-B999D70844FB@tarantool.org> <20200417063512.GA10928@tarantool.org> <1c1301d61489$a1af1790$e50d46b0$@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] sql: fix number and boolean sorting rules List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Timur Safin Cc: tarantool-patches@dev.tarantool.org Hi! Thanks for the review. > On Apr 17, 2020, at 10:27, Timur Safin wrote: >=20 > As a random bypasser I could not resist and not add my 5 kopecks (see = below). >=20 > : -----Original Message----- > : From: Mergen Imeev > :=20 > : Hi! Thank you for the fixes. I think that the your > : commit-message and comments sounds quite strange, but I am > : not sure that I am qualified enough to say that for sure. > : Please, send this patch to NIkita. Other than that, LGTM. > :=20 >=20 >=20 > : > commit 8a2133d84b88a050181d858d6109abf3635a121b (HEAD -> > : romanhabibov/gh-4697-scalar-bug, = origin/romanhabibov/gh-4697-scalar-bug) > : > Author: Roman Khabibov > : > Date: Mon Apr 13 05:03:54 2020 +0300 > : > > : > sql: fix number and boolean SCALAR sorting rules > : > > : > Make comparison SCALAR rules in the sql sorter correct for = number > : > and boolean. Boolean should always follow before any number. > : > > : > Closes #4697 > : > >=20 > Agreed with Mergen that message is confusing, I'd suggest to do this = simple replacement to make it clearer=20 >=20 > s/follow before/precede/g >=20 > Regards, > Timur >=20 Fixed. commit 386ba8676c0ebd381d9c03b2ebf80abd986de73b (HEAD -> = romanhabibov/gh-4697-scalar-bug, origin/romanhabibov/gh-4697-scalar-bug) Author: Roman Khabibov Date: Mon Apr 13 05:03:54 2020 +0300 sql: fix sorting rules for scalar =20 Sort values=E2=80=8Bin the correct order for scalar type when using = the vdbe sorter. Boolean always precedes number if it is sorted in ascending order. =20 Closes #4697 diff --git a/src/box/sql/vdbeaux.c b/src/box/sql/vdbeaux.c index b88726ea1..985c6ef54 100644 --- a/src/box/sql/vdbeaux.c +++ b/src/box/sql/vdbeaux.c @@ -3054,7 +3054,8 @@ sqlVdbeCompareMsgpack(const char **key1, rc =3D double_compare_uint64(pKey2->u.r, mem1.u.u, = -1); } else { - rc =3D (pKey2->flags & MEM_Null) ? +1 : = -1; + rc =3D (pKey2->flags & MEM_Null) !=3D 0 = || + (pKey2->flags & MEM_Bool) !=3D 0 ? = 1 : -1; } break; } @@ -3072,7 +3073,8 @@ sqlVdbeCompareMsgpack(const char **key1, rc =3D = double_compare_uint64(-pKey2->u.r, -mem1.u.i, = 1); } else { - rc =3D (pKey2->flags & MEM_Null) ? +1 : = -1; + rc =3D (pKey2->flags & MEM_Null) !=3D 0 = || + (pKey2->flags & MEM_Bool) !=3D 0 ? = 1 : -1; } break; } @@ -3096,7 +3098,8 @@ sqlVdbeCompareMsgpack(const char **key1, rc =3D +1; } } else { - rc =3D (pKey2->flags & MEM_Null) ? +1 : = -1; + rc =3D (pKey2->flags & MEM_Null) !=3D 0 = || + (pKey2->flags & MEM_Bool) !=3D 0 ? = 1 : -1; } break; } diff --git a/test/sql-tap/gh-4697-scalar-bug.test.lua = b/test/sql-tap/gh-4697-scalar-bug.test.lua new file mode 100755 index 000000000..6f600f27b --- /dev/null +++ b/test/sql-tap/gh-4697-scalar-bug.test.lua @@ -0,0 +1,35 @@ +#!/usr/bin/env tarantool +test =3D require("sqltester") +test:plan(2) + +-- +-- gh-4679: Make sure that boolean follow before any number within +-- scalar. Result with order by indexed (using index) and +-- non-indexed (using no index) must be the same. +-- +test:execsql [[ + CREATE TABLE test (s1 INTEGER PRIMARY KEY, s2 SCALAR UNIQUE, s3 = SCALAR); + INSERT INTO test VALUES (0, 1, 1); + INSERT INTO test VALUES (1, 1.1, 1.1); + INSERT INTO test VALUES (2, true, true); +]] + +test:do_execsql_test( + "scalar-bug-1.0", + [[ + SELECT s2, typeof(s2) FROM test ORDER BY s2; + ]], { + -- + true,"boolean",1,"integer",1.1,"double" + }) + +test:do_execsql_test( + "scalar-bug-2.0", + [[ + SELECT s3, typeof(s3) FROM test ORDER BY s3; + ]], { + -- + true,"boolean",1,"integer",1.1,"double" + }) + +test:finish_test()