From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3D0C69051CD; Tue, 19 Dec 2023 17:01:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3D0C69051CD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1702994503; bh=eM5vbaNVvME2fHyj/hccehIk3hr7Gs2WvYsq6F948ls=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=iKieAEweTbYPEojmIBJ/i0CmGR0tlGTOi0GrAmHe048dyDHAZp2Insv/s1h7uA1Ty /NZYr8hzWaL4lGZ5Wg9t6h2gDWVRq1saM37KzThUJeSJxVUDB2c7ALhOIh03Dpb04H 88tPaJf5ZlDy7TX2bD9ihqU7QUcA+2b4gHtOnaBI= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [95.163.41.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 367189051C1 for ; Tue, 19 Dec 2023 17:01:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 367189051C1 Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1rFafF-00HWyR-1m; Tue, 19 Dec 2023 17:01:41 +0300 Message-ID: <895df27c-4553-4914-a717-3e23d8a1b973@tarantool.org> Date: Tue, 19 Dec 2023 17:01:41 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org, skaplun@tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD97533543916A0F71AD15911439ECC4B5E02235F2F5915E4EDCD62213F67905E7A17D3B436B82FE3EFB0B6B3403344AAAC0C4F66EA89B2B8E5BC2FBDE9E7577831 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE788A2BECDB72C1542EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379A70878BADDF00B98638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A7FA2630BB5DF9A42FE3E87879A35E1E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAB5495298CADBD05A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B1593CA6EC85F86DF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C2D01283D1ACF37BA2D242C3BD2E3F4C64AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C319D302B05D018AA3BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF27ED053E960B195E1DD303D21008E298D5E8D9A59859A8B6D082881546D9349175ECD9A6C639B01B78DA827A17800CE71F4E386938175FB9731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A504107D35C9C3465CAC2B4B2D9F6A5594E69048E04F6EDF1BF87CCE6106E1FC07E67D4AC08A07B9B013BDA61BF53F5E1DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFB7C50A6CE75DDC63FAAC7C5663102F7CD673F3D5F1DE1D02C46E8FC69B2493D485EFCC6ECD454202E190DC598EAEA94F5CC17EDCC5C276D36BA1DE8A80991E97A74DFFEFA5DC0E7F02C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojgGTRFEPoGBTXxf56Ud057w== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A7694CDAC27227B97EA14F4668D9B66476BD87D154BA7A9C8918EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 4/6] memprof: remove unused arguments X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, Max thanks for the patch! LGTM On 12/6/23 21:55, Maxim Kokryashkin wrote: > Both `humanize.profile_info` and `process.form_heap_delta` > don't need the symtab, so the argument can be dropped. > > Part of tarantool/tarantool#5994 > --- > tools/memprof.lua | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/memprof.lua b/tools/memprof.lua > index e23bbf24..955a1327 100644 > --- a/tools/memprof.lua > +++ b/tools/memprof.lua > @@ -102,9 +102,9 @@ local function dump(inputfile) > local symbols = symtab.parse(reader) > local events = memprof.parse(reader, symbols) > if not leak_only then > - view.profile_info(events, symbols) > + view.profile_info(events) > end > - local dheap = process.form_heap_delta(events, symbols) > + local dheap = process.form_heap_delta(events) > view.leak_info(dheap) > view.aliases(symbols) > -- XXX: The second argument is required to properly close Lua