From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9B8CC6FC8E; Mon, 26 Apr 2021 12:21:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9B8CC6FC8E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619428884; bh=EIZMUbVTr3yXbWDR8AYqK33hS1T1JFrL8YmLNJSeTR8=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Qv42qzglwhEs+f5YP00EYYQkWzrhrEKpAegV3M0ofheEc2yIepM/EO+VMnBNQmU0K Z1X3B1t2gbwt3fqdt3B1c0KgfVyYqgijo/t/tjfwK/ah0HpcYjv2UUHGuIC1HAEqS7 WZ9mguu1LPW5dUtiGEdunvu9xbrv3Q9j1oYuY3C0= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5E6066FC8E for ; Mon, 26 Apr 2021 12:21:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5E6066FC8E Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1laxQg-0000rC-KM; Mon, 26 Apr 2021 12:21:23 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, gorcunov@gmail.com References: <8c48e98e0c9780e2fe4ffbf511ac95678561fcfe.1619219639.git.v.shpilevoy@tarantool.org> <2e89c2b4-fd13-2ca1-9c05-f8e95d2e92e6@tarantool.org> <0aed8e87-324f-01d0-c5d4-40a06d8006e7@tarantool.org> Message-ID: <894fb3c6-923f-dd21-e6da-8e3dd06b2669@tarantool.org> Date: Mon, 26 Apr 2021 12:21:22 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <0aed8e87-324f-01d0-c5d4-40a06d8006e7@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9203E2ABA940B7548357B9CFC828CE9D01715FF06786BA240182A05F5380850406750AB0181D9481BBCB381C0B25F99A854FCE27C2FA3325D35A4B8EF523913D1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70CB15FA6C489297DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376AFB9B40001E44068638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B20F989737D236F3CC592ADFF23503687306708AB62ED68B8ED2E47CDBA5A96583C09775C1D3CA48CF7EF884183F8E4D67117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE73AFA331E307B52169FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7C6A5C86E6400A7C2D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C0A2E2240085632A06CD04E86FAF290E2D7E9C4E3C761E06A71DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6D0C9BB9AE6BD5D69089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C97831226E49863DD59C42E6846C195B0237D3 X-C1DE0DAB: 0D63561A33F958A5589F21828B7FC4816854AA5A3DA9B559F4F744C73144E8B1D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D345B8C2BEC800D1021C9850EFCB509568E27156587AFDC3989A235E25131B7BE693B836016D6C589B81D7E09C32AA3244CB3621FBDBE21B4F084BD8B5F9813B304853296C06374E602FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmUj/IHfqgKc5M6G/vhfNpQ== X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F84903E956744D9D814F8BC53347452358F236D6C5F74DBBCB424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] fiber: make wakeup in Lua and C nop on self X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 25.04.2021 18:53, Vladislav Shpilevoy пишет: > Thanks for the review! > >>> + >>> +local function test_wakeup_self_and_wal_write(test) >>> +    test:plan(1) >>> + >>> +    local s = box.schema.create_space('test') >>> +    s:create_index('pk') >>> + >>> +    fiber.wakeup(fiber.self()) >>> +    local lsn = box.info.lsn >>> +    s:replace{1} >>> +    test:is(box.info.lsn, lsn + 1, 'written to WAL') >>> +    s:drop() >>> +end >> Again, shouldn't everything related to space creation, WAL writes and so on >> reside in box-tap ? I may be wrong, just asking. > It should, but this test is about testing the fibers, not > the box. Box and the WAL write here are secondary things. > The same as for app/fiber.test.lua (not TAP). Thanks for the explanation! LGTM. -- Serge Petrenko