From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 20B2C6EC40; Thu, 12 Aug 2021 21:56:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 20B2C6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628794611; bh=kdh9F399XZYw3v2TzmVzDvI+HF5vZCL91yz/6AKCsdw=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=B5uT58jKfKSdqByt3dlg1dHw6VqMxax+QqZYcvUSLBt/YdyenNwPwH/CfJ8X5NPho YMDUIwf1LLNp7xmtpOGLIotvrwvcHO/VDJEi/Vv5IaKBjs5ADsaWD1/6ogL4Ciplkm e1OXUTFkqqZKt4KG4ERUveXf0Zk9yIjCmdLGKCqA= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DC5D66EC40 for ; Thu, 12 Aug 2021 21:56:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DC5D66EC40 Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1mEFso-0006Sm-1X; Thu, 12 Aug 2021 21:56:50 +0300 To: Vladislav Shpilevoy , Mergen Imeev Cc: tarantool-patches@dev.tarantool.org References: <30b6e5331a79e14a0fdd0e5782aa7ac29c4922bb.1626358375.git.imeevma@gmail.com> <41ee6127-c53c-c964-a71c-c4a264f59ab0@tarantool.org> <20210810143251.GA471410@tarantool.org> Message-ID: <8928b369-4cff-0913-f691-7dfa9fda79d4@tarantool.org> Date: Thu, 12 Aug 2021 21:56:42 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD910164DC12A5633065676A9727AC27C74182A05F538085040A022034436A4076434CE607664520BFABFD31752689434F441E3C9C5B33D0CF2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379CBE0668FF2CDAD68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88A010634C35D4A9EB2C73CC36D66D6B8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C68E4D7E803FA7AD56136E347CC761E074AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C310DC912F9124C96EBA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7D699F3A2029486C7731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A591CE914A5F489958C3E6DB686974B6EE60CFD7C4F18AE52BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752DA3D96DA0CEF5C48E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A503FBFE8BE8FC496A186AFF9C908A89313BF6850AA24F3D42AE486165D7EE4E8C005613F4981B821D7E09C32AA3244C679FEF631DF944331762ED3C5EF45F9030452B15D76AEC14FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojKW4rnL99YhJF8V3l3CDg8A== X-Mailru-Sender: B5B6A6EBBD94DAD86A422A53D9D37A7DB4EE9387092F08F734830079F8E705F5B4934413F0E5D2431EC9E4A2C82A33BC8C24925A86E657CE0C70AEE3C9A96FBAB3D7EE8ED63280BE112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: define format of ephemeral spaces X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Safin Timur via Tarantool-patches Reply-To: Safin Timur Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 12.08.2021 21:32, Vladislav Shpilevoy via Tarantool-patches wrote: > Hi! Thanks for the fixes! > > See 7 comments below. > >> - if (def != NULL && i < def->part_count) { >> - assert(def->parts[i].type < field_type_MAX); >> - field->type = def->parts[i].type; >> - field->coll_id = def->parts[i].coll_id; >> - } else { >> - field->coll_id = COLL_NONE; >> - field->type = FIELD_TYPE_SCALAR; >> - } >> + struct key_part_def *parts = (void *)fields + parts_indent; > > 2. Are you sure void * + integer works bytewise? Shouldn't it be > cast to char * to move the pointer? In other places you use char *. Good point. Such void pointer arithmetic is gcc specific language extension (https://gcc.gnu.org/onlinedocs/gcc/Pointer-Arith.html), and is not a standard approach. Timur