From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.perepelitsa@corp.mail.ru>
Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BB4DA469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 12 May 2020 20:06:09 +0300 (MSK)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
From: Mons Anderson <v.perepelitsa@corp.mail.ru>
In-Reply-To: <20200508161910.GC51428@grain>
Date: Tue, 12 May 2020 20:06:07 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <88CA17D1-8D58-4FDC-9547-19D99C54DA39@corp.mail.ru>
References: <20200508114714.426908-1-gorcunov@gmail.com>
 <7d39ce8a-3c12-a814-9bb3-8d43bfc6f782@tarantool.org>
 <20200508161910.GC51428@grain>
Subject: Re: [Tarantool-patches] [PATCH 0/7] box/console: add support for
 internal types
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

> On 8 May 2020, at 19:19, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
>=20
> On Fri, May 08, 2020 at 07:04:26PM +0300, Oleg Babin wrote:
>> Hi! Thanks for patchset! I have a few comments.
>>=20
>> I'm not sure that we should return errors in such way:
>> ```
>> tarantool> x
>> {error =3D "[string \"return x\"]:1: variable \'x\' is not =
declared"};
>> ```
>=20
> Yes. This allows to paste the result back to the console.
> This is change in behaviour but while we're not claiming
> that th lua mode is stable I think we can do so.

Then it would be great to return it as

error =E2=80=9C[string \"return x\"]:1: variable \'x\' is not declared"

or even better

error [[[string "return x"]:1: variable 'x' is not declared]]

>=20
>>=20
>> Or is it expected behaviour?
>>=20
>> Also `nil` value is ignored in some cases.
>> ```
>> tarantool> nil
>> ;
>> tarantool> nil, 2, 3
>> ;
>> tarantool> 1, nil, 3
>> 1, nil, 3;
>> ```
>=20
> Thanks! I'll take a look.


There is a possibility to take a length or result (select(=E2=80=98#=E2=80=
=99,...))