From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E29C32F26E for ; Thu, 1 Nov 2018 11:27:58 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7TCI0LrJ97VO for ; Thu, 1 Nov 2018 11:27:58 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9EADD2F24A for ; Thu, 1 Nov 2018 11:27:58 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v5 07/12] lib: introduce json_path_normalize routine References: <134d5b3da2e0d0102287cceb4d347c88ef2616b5.1540795996.git.kshcherbatov@tarantool.org> <20181101152200.GH30032@chai> From: Kirill Shcherbatov Message-ID: <88101bba-75d3-0c44-a0af-fb4d66b1945d@tarantool.org> Date: Thu, 1 Nov 2018 18:27:55 +0300 MIME-Version: 1.0 In-Reply-To: <20181101152200.GH30032@chai> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Kostya Osipov > Let's try to avoid this altogether. We could use parent references > to check if path1 equals to path2. This required in index_def_is_valid to raise error on key_part_path_cmp == 0 before tuple_format creation. We need to compare path strings in key_part(s)