From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 34BEF50D8D2; Tue, 25 Jul 2023 15:26:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 34BEF50D8D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1690287968; bh=PJmLZ8IfzBlMsh+1gpUOAdDOPTcDOqQoCRQffJGK/7k=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=k1DyxPsK/C93yJwuapY3hiGEHIFJ21z0bwMC7dG2LiXGmUQi/mQS1BRjTZ8KFJhZp KB9xmE9sTvsE7UU9QDTPJXFTXWYfT97k4ZVIOo7giItAJwGihXlEd0/CTHGNyomtIl vR1t7GnF10SJMhNcSPqQB4UUmS6+pm6CCi0kNviw= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4C08250D8D2 for ; Tue, 25 Jul 2023 15:26:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4C08250D8D2 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qOH76-0006Ot-Vr; Tue, 25 Jul 2023 15:26:05 +0300 Message-ID: <87f18ea0-679c-3973-acf8-5a3be8b0b035@tarantool.org> Date: Tue, 25 Jul 2023 15:26:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Igor Munkin , Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9262A61978FA98776BE79A70C8AC8EC357A4DD73CDDFB4D4D182A05F5380850404C228DA9ACA6FE27E8C93DD8891AAC28962DE41B645BD8158E17478930AFC165DDA4EBEB9A524A2A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE711269A7C2F827F16EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DC5B68A43B0CFEA28638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EE45D2FADB9B7F83BA2BB6251D79B6EA117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C65AC60A1F0286FEC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C02BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735026D3A1080F4EF5CC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5B60FD25216166D8BD28400127133B101C684D9C40E9CB2EDF87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFD508357D41739774F11B4328E4A5F9DE8D10360F6F393B920416C631D1411E1338B8486FBA2B5E2D2D8A5E5B53F5BD04E5331EAFC70ABB30BCB72D30AED5B844E48CAC7CA610320002C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojQWAQuM+Ftg9lKoFzkj1anw== X-DA7885C5: 6535DB07397E906FAE64D7AAF830186FCC2F0E0CB0265A96111B04727FD398A9262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B7B181FAE51E3AD0669EB302CBDA001BDDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 4/5] build: introduce LUAJIT_USE_ASAN option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, again On 7/21/23 11:12, Igor Munkin wrote: > +option(LUAJIT_USE_ASAN "Build LuaJIT with AddressSanitizer" OFF) > +if(LUAJIT_USE_ASAN) > + if(NOT LUAJIT_USE_SYSMALLOC) > + message(WARNING > + "Unfortunately, internal LuaJIT memory allocator is not instrumented yet," > + " so to find any memory errors it's better to build LuaJIT with system" > + " provided memory allocator (i.e. run CMake configuration phase with" > + " -DLUAJIT_USE_SYSMALLOC=ON)." > + ) > + endif() > + # Use all recomendations described in AddressSanitize docs: > + # https://clang.llvm.org/docs/AddressSanitizer.html. > + AppendFlags(CMAKE_C_FLAGS > + # Enable hints for AddressSanitizer (see src/lj_str.c). > + -DLUAJIT_USE_ASAN > + # XXX: To get nicer stack traces in error messages. > + -fno-omit-frame-pointer > + # Enable AddressSanitizer support. > + -fsanitize=address > + ) > +endif() > I suspect we need set in LUAJIT_USE_SYSMALLOC in cmake/luajit.cmake [1] on next LuaJIT bump, right? Otherwise Tarantool CI will fail. 1. https://github.com/tarantool/tarantool/blob/1cda22aaaf7eb1f0880f4c70f2c79ce27a9604ce/cmake/luajit.cmake#L74-L76 > # --- Main source tree --------------------------------------------------------- >