From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1E7554C885; Thu, 14 Jan 2021 12:51:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1E7554C885 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610617913; bh=JU+ZfuUL+2DIZmSWBYC1FJQzBKNX4u+MZsPpa/mdXIE=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=VyylICHZWBP/VRZBm/A77ezgvmxzkXieQof/VyrTp7Hig0mq5viD3iDcuKjR+hW+M wHFcV7OMBnosL/AEJR0OXr/wnWzXgSsHGSip9/47QgGrAjDCV+J/e6HoNnesFDiASg h3nlB9/mDb93O/D8b3a6RGVKrffkEd7x3u/dR5fQ= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 135C74C885 for ; Thu, 14 Jan 2021 12:51:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 135C74C885 Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1kzzIE-0004HB-Dt; Thu, 14 Jan 2021 12:51:50 +0300 To: Leonid Vasiliev , tarantool-patches@dev.tarantool.org Cc: Sergey Bronnikov , alexander.turenko@tarantool.org References: <28dc6d930bc93ece50cce5ba5f37b2eab4bdf50d.1610526975.git.estetus@gmail.com> Message-ID: <87cf6847-fbc1-c51d-6b5d-f1400e0edcf8@tarantool.org> Date: Thu, 14 Jan 2021 12:51:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CD9B382B274FF537389656BC690FF7BBE200894C459B0CD1B9202562F7356475B853FAF2B9E2754EEC5D3D06EE5197295979C523755529B03C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CE4525FFB91B9BBCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378A9F193E39E334918638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC20F4D7051A80631831AF6D095520F9951D8FE07F95D7EA99389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22499129948AB3BEADC776E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B170D2402AFAE94353AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE7F9581457D50944AB67F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C377DC896192EAD7AA35872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9DE2850DD75B2526BE5BFE6E7EFDEDCD789D4C264860C145E X-C1DE0DAB: 0D63561A33F958A556C403DDDF6025FACE4C0A6EEE7F1D31580F7AEF949FEC54D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758F9E841AEAEC4F2C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3416EA6E382A5BB176DC6A5809F9F7E7399A4333B44403FE613178C9E81A1586EEBC3C93835955AE7D1D7E09C32AA3244CE5DCD8EF6BC034A84B6F55C925B9ED39BBA718C7E6A9E042927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj9kdO2HH36x7vNdDhwYmSuA== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F258845817E654FFDFC3364C40634C083A583D5C052FD7240E6EB60E282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 2/4] test: fix xlog-py/big_lsn.test.py X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for review! On 14.01.2021 12:02, Leonid Vasiliev wrote: > Hi! Thank you for the patch. > LGTM. > > On 13.01.2021 11:48, sergeyb@tarantool.org wrote: >> From: Sergey Bronnikov >> >> Set correct encoding on opening file. >> >> Part of #5538 > > AFAIU, if the task has been closed, new patches corresponding with the > task are marked as "Follows up". > Fixed! >> --- >>   test/xlog-py/big_lsn.test.py | 3 ++- >>   1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/test/xlog-py/big_lsn.test.py b/test/xlog-py/big_lsn.test.py >> index edc1e5620..73dcf7a48 100644 >> --- a/test/xlog-py/big_lsn.test.py >> +++ b/test/xlog-py/big_lsn.test.py >> @@ -1,4 +1,5 @@ >>   import os >> +import codecs >>     # >>   # Check that Tarantool handles huge LSNs well (gh-4033). >> @@ -17,7 +18,7 @@ new_lsn = 123456789123 >>   wal_dir = os.path.join(server.vardir, server.name) >>   old_wal = os.path.join(wal_dir, "%020d.xlog" % old_lsn) >>   new_wal = os.path.join(wal_dir, "%020d.xlog" % new_lsn) >> -with open(old_wal, "r+") as f: >> +with codecs.open(old_wal, "r+", encoding = "ISO-8859-1") as f: >>       s = f.read() >>       s = s.replace("VClock: {{1: {}}}".format(old_lsn), >>                     "VClock: {{1: {}}}".format(new_lsn)) >>