From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8B20A430409 for ; Thu, 20 Aug 2020 11:06:02 +0300 (MSK) From: "Alexander V. Tikhonov" Date: Thu, 20 Aug 2020 11:05:57 +0300 Message-Id: <87c28236a265e7ab43072bc89b0a3a11339f7631.1597910696.git.avtikhon@tarantool.org> Subject: [Tarantool-patches] [PATCH v1] test: remove asan suppression for unit/msgpack List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Yukhin , Alexander Turenko Cc: tarantool-patches@dev.tarantool.org ASAN should the issue in msgpuck repository in file test/msgpack.c which was the cause of the fail in unit/msgpack test. The issue was fixed in msgpuck repository and ASAN suppression was removed for it. Also removed skip condition file, which blocked the test when it failed. Part of #4360 --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/asan-restore Issue: https://github.com/tarantool/tarantool/issues/4360 asan/asan.supp | 4 ---- src/lib/msgpuck | 2 +- test/unit/msgpack.skipcond | 7 ------- 3 files changed, 1 insertion(+), 12 deletions(-) delete mode 100644 test/unit/msgpack.skipcond diff --git a/asan/asan.supp b/asan/asan.supp index 24cb0845a..95a662461 100644 --- a/asan/asan.supp +++ b/asan/asan.supp @@ -4,7 +4,3 @@ # File format: #fun:* #src:* - -# !test: unit/msgpack.test -# source: src/lib/msgpuck/test/msgpuck.c -fun:test_mp_print diff --git a/src/lib/msgpuck b/src/lib/msgpuck index 3cc63d3d1..a843861f7 160000 --- a/src/lib/msgpuck +++ b/src/lib/msgpuck @@ -1 +1 @@ -Subproject commit 3cc63d3d1d17c022894d8fb095c5d3dc3ae270aa +Subproject commit a843861f7124f257bbd505fac8dbfb5708ecc855 diff --git a/test/unit/msgpack.skipcond b/test/unit/msgpack.skipcond deleted file mode 100644 index e46fd1088..000000000 --- a/test/unit/msgpack.skipcond +++ /dev/null @@ -1,7 +0,0 @@ -import os - -# Disabled at ASAN build due to issue #4360. -if os.getenv("ASAN") == 'ON': - self.skip = 1 - -# vim: set ft=python: -- 2.17.1