From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9692728821 for ; Thu, 29 Aug 2019 16:43:09 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1XOmmOG89Z8k for ; Thu, 29 Aug 2019 16:43:09 -0400 (EDT) Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 41F3128826 for ; Thu, 29 Aug 2019 16:43:09 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 7/8] netbox: allow passing options to :execute() References: From: Vladislav Shpilevoy Message-ID: <87739a43-c994-7211-ba42-ab67dbf3dd25@tarantool.org> Date: Thu, 29 Aug 2019 22:46:22 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Nikita Pettik Cc: kostja@tarantool.org, alexander.turenko@tarantool.org Thanks for the patch! On 27/08/2019 15:34, Nikita Pettik wrote: > To implement dry-run execution, let's allow 'options' be valid argument > of :execute() method. SQL options are encoded with IPROTO_OPTIONS > request key. Options are supposed to be a map of named parameters or a > list of unnamed (considering their order). The only currently available > option is 'dry_run' with boolean values. Now it doesn't affect anything, > but will allow to get meta-information of query execution. Why do you need an array of unnamed options? Such thing will be impossible to maintain. Each time you will add a new option, you will extend this array, and to pass that option a user would need to pass all the previous ones. Please, drop arrays support.