From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4899325BBE for ; Wed, 13 Jun 2018 04:48:06 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vkX0Uo2YvDKL for ; Wed, 13 Jun 2018 04:48:06 -0400 (EDT) Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 58E3525C0F for ; Wed, 13 Jun 2018 04:48:04 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: drop useless legacy Cursor hints References: <1528580490.331665582@f480.i.mail.ru> <44295e51-aabe-27f9-8331-6d30387a3551@tarantool.org> From: Vladislav Shpilevoy Message-ID: <871fb50b-d725-f8b6-10b6-8c8513473a24@tarantool.org> Date: Wed, 13 Jun 2018 11:48:00 +0300 MIME-Version: 1.0 In-Reply-To: <44295e51-aabe-27f9-8331-6d30387a3551@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Kirill Shcherbatov Hello. Thanks for the fixes! LGTM. On 13/06/2018 09:43, Kirill Shcherbatov wrote: >> 1. The same comment. What have you write after '---'? > Ok, I'll try to do not forget about it in next time. It were not obvious for me to edit ./create_commits.sh result files. ./create_commits.sh is not a standard util. It is just my helper for multi-commit patches. If you know how, you can implement Branch/Issue adding for single-commit patches, and I will share it. > > Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3121-useless-hints > Issue: https://github.com/tarantool/tarantool/issues/3121 > >> 2. I have pushed my fixes as a separate commit. Please, >> look, perceive and squash. > Done. Tnx. >