From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH] box: add tuple:size function References: <1538070923-23087-1-git-send-email-ivushkinalex@gmail.com> <20181005102321.eyhdkng2ymu5q6jc@esperanza> From: Vladislav Shpilevoy Message-ID: <8704964c-ac90-583f-c9ab-fc4dde847184@tarantool.org> Date: Sat, 6 Oct 2018 16:58:46 +0300 MIME-Version: 1.0 In-Reply-To: <20181005102321.eyhdkng2ymu5q6jc@esperanza> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: tarantool-patches@freelists.org, Vladimir Davydov , AlexeyIvushkin List-ID: On 05/10/2018 13:23, Vladimir Davydov wrote: > On Thu, Sep 27, 2018 at 08:55:23PM +0300, AlexeyIvushkin wrote: >> diff --git a/src/box/lua/tuple.lua b/src/box/lua/tuple.lua >> index 63ea73e..801ee3c 100644 >> --- a/src/box/lua/tuple.lua >> +++ b/src/box/lua/tuple.lua >> @@ -286,6 +286,7 @@ local methods = { >> ["update"] = tuple_update; >> ["upsert"] = tuple_upsert; >> ["bsize"] = tuple_bsize; >> + ["size"] = internal.tuple.size; >> ["tomap"] = internal.tuple.tuple_to_map; > > Why did you decide to introduce a new function rather than fixing > tuple.bsize, as it was explicitly requested in the ticket? It breaks compatibility. Now bsize returns only Message Pack part of tuple despite what the documentation says. >