From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9426918EFF0; Tue, 6 Dec 2022 00:44:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9426918EFF0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1670276643; bh=wnSudiMoRXSG9PMO1qLfW4OBP1Idr978ZTNm5Lo95l4=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Fj46VYN33SomQJM724I/8bA78DAnBVxGENA2vxQfibbLIENYvpdeMcuxsaf9tQiaW 1q2gHQrPPmkoQRnk1UNDF837gwGOM9QWmQWs4wVpwvKlhqzY4ebhyuzMqLQLWAmRe9 +ZBP72dGESk/ZIbbKtnXvVQlWFvcX3FnAiDzbBc8= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E0BAE7036F for ; Tue, 6 Dec 2022 00:44:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E0BAE7036F Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1p2JFq-0005iv-5K; Tue, 06 Dec 2022 00:44:02 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\)) In-Reply-To: <20221028092638.11506-6-max.kokryashkin@gmail.com> Date: Tue, 6 Dec 2022 00:43:51 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <86C4DA8F-416D-40B9-ABC9-EB86218BAADE@tarantool.org> References: <20221028092638.11506-1-max.kokryashkin@gmail.com> <20221028092638.11506-6-max.kokryashkin@gmail.com> To: Maksim Kokryashkin X-Mailer: Apple Mail (2.3731.200.110.1.12) X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD908190A22B884CF14738915A035816C578D9B2BBAF89147E4182A05F53808504020486E04736316FD0523DA32C062995DB203EA06043BCACA17A73C6AFAD11112 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE745C0EDBD94D46193EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378A9F193E39E334918638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D899E626B25398D6EB9F0E36E7F796FF18117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC05EF1B56D39DD5F7389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC85149A672E96B27E1F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C1E1736EDDE8D47902D242C3BD2E3F4C64AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C39B5048E0FA8C4E96BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7A3CCBC2573AEBDE1C4224003CC83647689D4C264860C145E X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34FDC9529E4578B99CB6ED90CE18DDA37B06493D88406972BD982EA6F8AC33A24E3417A2E314822B831D7E09C32AA3244C20732D4454A6242E02111539B0A2E36855E75C8D0ED9F6EE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojniwsktXAgUPd9S92TztIZA== X-Mailru-Sender: 5AA3D5B9D8C486464BD4402E82A444E30C60CD3D6E2382B6562590C29A0EBC3F5B2BEBD93A05268F19381EE24192DF5555834048F03EF5D4C9A814A92B2E3B1BA4250FC3964EA4964198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v4 5/8] OSX/ARM64: Disable unwind info. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: sergos via Tarantool-patches Reply-To: sergos Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! LGTM. Sergos > On 28 Oct 2022, at 12:26, Maksim Kokryashkin = wrote: >=20 > From: Mike Pall >=20 > See #698. >=20 > (cherry picked from commit 78350a2565e1cf1102bcd25be406f02953d4dd3b) >=20 > External unwinding support is already disabled for OSX on ARM64 > platform so there is no point in generation of incorrect unwind > info for it. This patch disables that generation for the commit > history match, and it will be re-enabled in the next commit, > which contains the fix for the issue. >=20 > Maxim Kokryashkin: > * added the description for the problem >=20 > Needed for tarantool/tarantool#6096 > Part of tarantool/tarantool#7230 > --- > src/vm_arm64.dasc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/src/vm_arm64.dasc b/src/vm_arm64.dasc > index ad57bca3..ccfa72bd 100644 > --- a/src/vm_arm64.dasc > +++ b/src/vm_arm64.dasc > @@ -3990,7 +3990,8 @@ static void emit_asm_debug(BuildCtx *ctx) > ".LEFDE3:\n\n", (int)ctx->codesz - fcofs); > #endif > break; > -#if !LJ_NO_UNWIND > + /* Disabled until someone finds a fix. See #698. */ > +#if !LJ_NO_UNWIND && 0 > case BUILD_machasm: { > #if LJ_HASFFI > int fcsize =3D 0; > --=20 > 2.37.0 (Apple Git-136) >=20