From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BDBEB4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 10 Apr 2020 03:00:37 +0300 (MSK)
References: <cover.1586412430.git.lvasiliev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <865fb768-3c90-ec8e-96cf-7d7598a9f6e0@tarantool.org>
Date: Fri, 10 Apr 2020 02:00:36 +0200
MIME-Version: 1.0
In-Reply-To: <cover.1586412430.git.lvasiliev@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] Adapt luarocks for
 tarantoolctl
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Leonid Vasiliev <lvasiliev@tarantool.org>
Cc: Yaroslav Dynnikov <Yaroslav.dynnikov@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi!

Thanks for the patchset!

LGTM.

But please, next time don't silently respond with a new patch
on my comments. I may be wrong sometimes. Honestly I am wrong
quite often. Like Vladimir said once, "mailing list exists for
discussions".

I added Yaroslav to CC since he expressed a will to join the
review.

On 09/04/2020 08:33, Leonid Vasiliev wrote:
> https://github.com/tarantool/tarantool/issues/4629
> https://github.com/tarantool/luarocks/tree/lvasiliev/gh-4629-add-chdir-to-make
> See corresponding patch for tarantoolctl
> (https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4629-forward-flags)
> 
> Motivation:
> Imperfect integretion of the Luarocks to tarantoolctl
> (malfunctioning flags, disabled commands)
> 
> Was done:
> whitelist of tarantoolctl don't used for luarocks flags
> Option chdir has been moved from tarantoolctl to luarocks
> 
> @ChangeLog - see a comment in tarantool
> 
> Leonid Vasiliev (2):
>   Add the chdir option for make
>   Delete flags which can't be used with tarantoolctl rocks
> 
>  src/luarocks/cmd/help.lua | 5 -----
>  src/luarocks/cmd/make.lua | 8 ++++++++
>  src/luarocks/util.lua     | 5 +----
>  3 files changed, 9 insertions(+), 9 deletions(-)
>