From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 414BF29E96 for ; Wed, 20 Mar 2019 11:12:50 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dfKzIbG6LAGg for ; Wed, 20 Mar 2019 11:12:50 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 66B6F29E33 for ; Wed, 20 Mar 2019 11:12:49 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [tarantool-patches] Re: [PATCH v2 3/9] box: fix Tarantool upgrade from 2.1.0 to 2.1.1 From: "n.pettik" In-Reply-To: <4F67EA78-E237-4424-BEF6-ECE8ADCD5CBF@tarantool.org> Date: Wed, 20 Mar 2019 18:12:46 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <860C81EF-4B1E-4648-A638-C804DB32A3EF@tarantool.org> References: <1e4434445b60b5a5e0c3b289505595b0e00c8f8c.1548838034.git.kshcherbatov@tarantool.org> <4F67EA78-E237-4424-BEF6-ECE8ADCD5CBF@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov > On 12 Mar 2019, at 14:45, n.pettik wrote: >=20 >> Tarantool could not start from the snapshot created by version >> 2.1.0 because the new version 2.1.1 does not support the >> index.opts.sql index opt and stops the execution. >> Introduced a special state OPT_DEF_LEGACY macro to ignore legacy >> options and introduced migration code in upgrade.lua. >=20 > As for me, it looks satisfying, but I strongly recommend you to ask > other members of server team for comments on this approach. > Will there be other =E2=80=9Clegacy=E2=80=9D options, or in the = nearest future this is > going to be the only one? Moreover, opts_parse_key already features > =E2=80=9Cskip_unknown_options=E2=80=9D param - could we skip =E2=80=9Csq= l=E2=80=9D option using it > (ofc considering some workaround)? >=20 > Again, since it is not directly related to the main patch-set, let=E2=80= =99s > consider it as independent.=20 LGTM.=