From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 189B64765E0
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 24 Dec 2020 21:22:13 +0300 (MSK)
References: <20201223154155.234884-1-gorcunov@gmail.com>
 <20201223154155.234884-5-gorcunov@gmail.com>
 <30a781d7-4f4e-3543-f67e-2fb1f7cce172@tarantool.org>
 <20201223212253.GA298600@grain> <20201224131601.GB298600@grain>
 <8c0b2bda-5614-eac0-c0b9-36630c4bf315@tarantool.org>
 <20201224173331.GC298600@grain>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <85d69b97-64d2-4f42-737f-ed7a7ea6d5d1@tarantool.org>
Date: Thu, 24 Dec 2020 19:22:10 +0100
MIME-Version: 1.0
In-Reply-To: <20201224173331.GC298600@grain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v5 4/4] crash: report crash data to
 the feedback server
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

I applied this diff and pushed to master.

====================
--- a/src/lib/core/crash.c
+++ b/src/lib/core/crash.c
@@ -327,21 +327,17 @@ crash_report_feedback_daemon(struct crash_info *cinfo)
 	snprintf_safe("}");
 	snprintf_safe("}");
 
-	/*
-	 * Finalize the "data" key and the script.
-	 *
-	 * The timeout is choosen to be 1 second as
-	 * main feedback daemon uses.
-	 */
+	/* Finalize the "data" key and the whole dump. */
 	size = e - p;
 	snprintf_safe("}");
 	snprintf_safe("}");
 
-	pr_debug("crashinfo script: %s", head);
+	pr_debug("crash dump: %s", head);
 
 	char *exec_argv[7] = {
 		[0] = tarantool_path,
 		[1] = "-e",
+		/* Timeout 1 sec is taken from the feedback daemon. */
 		[2] = "require('http.client').post(arg[1],arg[2],{timeout=1});"
 		      "os.exit(1);",
 		[3] = "-",