From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: Cyrill Gorcunov <gorcunov@gmail.com> Cc: tml <tarantool-patches@dev.tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v5 4/4] crash: report crash data to the feedback server Date: Thu, 24 Dec 2020 19:22:10 +0100 [thread overview] Message-ID: <85d69b97-64d2-4f42-737f-ed7a7ea6d5d1@tarantool.org> (raw) In-Reply-To: <20201224173331.GC298600@grain> I applied this diff and pushed to master. ==================== --- a/src/lib/core/crash.c +++ b/src/lib/core/crash.c @@ -327,21 +327,17 @@ crash_report_feedback_daemon(struct crash_info *cinfo) snprintf_safe("}"); snprintf_safe("}"); - /* - * Finalize the "data" key and the script. - * - * The timeout is choosen to be 1 second as - * main feedback daemon uses. - */ + /* Finalize the "data" key and the whole dump. */ size = e - p; snprintf_safe("}"); snprintf_safe("}"); - pr_debug("crashinfo script: %s", head); + pr_debug("crash dump: %s", head); char *exec_argv[7] = { [0] = tarantool_path, [1] = "-e", + /* Timeout 1 sec is taken from the feedback daemon. */ [2] = "require('http.client').post(arg[1],arg[2],{timeout=1});" "os.exit(1);", [3] = "-",
next prev parent reply other threads:[~2020-12-24 18:22 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-23 15:41 [Tarantool-patches] [PATCH v5 0/4] Our feedback daemon sends only a few portions of usage Cyrill Gorcunov 2020-12-23 15:41 ` [Tarantool-patches] [PATCH v5 1/4] util: introduce strlcpy helper Cyrill Gorcunov 2020-12-23 15:41 ` [Tarantool-patches] [PATCH v5 2/4] backtrace: allow to specify destination buffer Cyrill Gorcunov 2020-12-23 15:41 ` [Tarantool-patches] [PATCH v5 3/4] crash: move fatal signal handling in Cyrill Gorcunov 2020-12-23 15:41 ` [Tarantool-patches] [PATCH v5 4/4] crash: report crash data to the feedback server Cyrill Gorcunov 2020-12-23 18:47 ` Vladislav Shpilevoy 2020-12-23 18:57 ` Cyrill Gorcunov 2020-12-23 21:22 ` Cyrill Gorcunov 2020-12-24 13:16 ` Cyrill Gorcunov 2020-12-24 17:15 ` Vladislav Shpilevoy 2020-12-24 17:33 ` Cyrill Gorcunov 2020-12-24 18:22 ` Vladislav Shpilevoy [this message] 2020-12-24 18:33 ` Cyrill Gorcunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=85d69b97-64d2-4f42-737f-ed7a7ea6d5d1@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v5 4/4] crash: report crash data to the feedback server' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox