From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BD6126EC40; Fri, 2 Jul 2021 14:47:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BD6126EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625226470; bh=ijGGY140+yzmqh2LnBSKiqm/LTnn9a7n+yoDeHjKA8A=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=fAi3zeLJjen9cGZMvMsu/ZQvJZVgTqVjpO+4fxUpQxn8VzTTi/EvblMfaS2QFjNwZ qNbVdwzO54I1kpUtJ4fgT9PEW5V+Nn4PBo+rHG/U08CMhMoFwnQraV3gHWzHgnwcg8 MxaHF1P7lBpC7omKg9D5CBEnsoE1XF/PWXLZib6o= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 25CAE6EC40 for ; Fri, 2 Jul 2021 14:47:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 25CAE6EC40 Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1lzHe8-0007ms-FQ; Fri, 02 Jul 2021 14:47:48 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org References: <888cee3d83fff78411e0cf96ee6b2e8292887677.1625177221.git.v.shpilevoy@tarantool.org> Message-ID: <85b44610-ba58-75af-07ec-7ae4dc66d372@tarantool.org> Date: Fri, 2 Jul 2021 14:47:47 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <888cee3d83fff78411e0cf96ee6b2e8292887677.1625177221.git.v.shpilevoy@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB2F1AA0EB8A504C8721532AB396CDCF09182A05F538085040EB5E670B1EDAC97E3D8C1C29D8E5C379B822B2F3E37F390EA5201446AE708EBA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D99F96657F58F1038638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D87C4995C4D3D03212897BB081118532C8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAB5495298CADBD05A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735209647ADFADE5905B16FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4B4782AAF36435267CD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE37BD21ED50D08CA4DBA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE74ABCC139FF3F849B731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A54EA99429747B76AC2A74B0BE630F65FE6C739264837D1224D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753753CEE10E4ED4A7410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34103A2CD2CFC42C6730C7AF838ACBE57440F8E811CC3A4148566C11F4CD50EB3AEC05F1A845C74D0D1D7E09C32AA3244CCB3703CC9A49B102017C733F577B0F433FD9C8CA1B0515E0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj/yEXjM+E11DaDwzY4QfvtA== X-Mailru-Sender: 583F1D7ACE8F49BD07526C4546A62CBF2BB51055364E0C8A8923EC2862CB8F31BC8E1D9BDBE7A71123E75C7104EB1B885DEE61814008E47C7013064206BFB89F93956FB04BA385BE9437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 4/6] config: introduce master 'auto' replicaset option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for your patch. LGTM. One nit below. On 02.07.2021 01:09, Vladislav Shpilevoy wrote: > The new option will enable auto-search for master on the marked > replicasets. > > Part of #75 > --- > > +local function check_replicaset_master(master, ctx) > + if not lutil.version_is_at_least(1, 10, 0) then > + error('Only versions >= 1.10 support master discovery') > + end If we talk about "is_async" netbox option. We should check 1.10.1: https://github.com/tarantool/tarantool/commit/0f686829a89b87d4f8d10fd25d4acfdea9b3dc60#diff-1e545a3af3d3592423eff523367e962e18f7eda45c2f9bef6994a254f6044d70 There is a gap between 1.10.0 and 1.10.1 when there is no is_async. Feel free to ignore. I don't believe it will happen ever. > + if master ~= 'auto' then > + error('Only "auto" master is supported') > + end > +end > +