From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4F648C5B2C3; Thu, 22 Aug 2024 17:12:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4F648C5B2C3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724335943; bh=PkHwV387VkxxQeeFfFGPL43i8pUpyO5hRJ9A0QMcm74=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=lo62k4QOhuabLO886kvsdplZwcR1KqIAAVKjvvqiBzV6qHIyIJFWazVkEr6ZLe0rw rHJF988haupDS/3qHg03hfcDzjfpxcz+7QzLwosF+Z0ONeriynI8xVPDt3iMUK/xbW z4Py3Y9mgZVMjHMPToJykk7rGcL3438ROHsTnC9s= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [95.163.41.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 04646C5B2C0 for ; Thu, 22 Aug 2024 17:12:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 04646C5B2C0 Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1sh8Y1-0000000AK6F-23pL; Thu, 22 Aug 2024 17:12:21 +0300 Content-Type: multipart/alternative; boundary="------------UxONeowaoWdbecvPFqS1UZX6" Message-ID: <85686516-06c9-4215-abe0-f779471391dd@tarantool.org> Date: Thu, 22 Aug 2024 17:12:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <21d553d0dc7347f32cd78a99e0627c4e1e6d8081.1724228998.git.skaplun@tarantool.org> In-Reply-To: <21d553d0dc7347f32cd78a99e0627c4e1e6d8081.1724228998.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9A67092BE052B1D9E80479E83A5F5ECBCB411FF80AE7BBDAB182A05F538085040E9CEB900D8505A32C591814E25D11F9F86DBCE93F13C550CB32D9F4D3AE59E647CBF1C18CED4D92F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B114C2C2C20B7E62EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E893C22CB255350D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D868B49192462E8ADB9FB0B239FB5487F2B8D4503E34EC248DCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637DCE3DBD6F8E38AFD389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063741880789376DFC6ED81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE7541FADD3D81556A7EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3045DD857D6FE754135872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5AB51B675E6A4C6925002B1117B3ED696100AA4A3EA7C0469A9DAB4B68AE4D22F823CB91A9FED034534781492E4B8EEAD69BF13FED57427F1BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF87C494284606BE82B25748B31DBE4C89D9DD5281A581EB141CAA7CCC9B914D17AFE07996864E0BE22FB0CAD32ADFBF8400877211E1D150ACB07BABCAF5F419F952A264F3D6D7873F5F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbUwDRTee1Xow9hVYG6j/Lw== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140BA75CA84F86F657A0898C0106A560F9149D75DF240DB21480152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 37/45] test: refactor LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------UxONeowaoWdbecvPFqS1UZX6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sergey, On 21.08.2024 11:58, Sergey Kaplun wrote: > This patch refactors the aforementioned test to make its code style > closer to ours. > > Relates to tarantool/tarantool#9398 > --- thanks for the patch! LGTM > test/LuaJIT-tests/trace/tcall_base.lua | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/test/LuaJIT-tests/trace/tcall_base.lua b/test/LuaJIT-tests/trace/tcall_base.lua > index 7d8d75e0..65fc118e 100644 > --- a/test/LuaJIT-tests/trace/tcall_base.lua > +++ b/test/LuaJIT-tests/trace/tcall_base.lua > @@ -1,11 +1,11 @@ > local r = 0 > local function g() > r = r + 1 > - for i=1,100 do end > + for _ = 1, 100 do end > end > > local function f() > - for j=1,20 do > + for j = 1, 20 do > if j > 19 then > return g() -- Tailcall at base. > -- Let this link to the already compiled loop in g(). > @@ -15,6 +15,6 @@ end > > do --- Recording tailcall at base slot. > g() -- Compile this loop first. > - for i=1,50 do f() end > + for _ = 1, 50 do f() end > assert(r == 51) > end --------------UxONeowaoWdbecvPFqS1UZX6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Sergey,

On 21.08.2024 11:58, Sergey Kaplun wrote:
This patch refactors the aforementioned test to make its code style
closer to ours.

Relates to tarantool/tarantool#9398
---
thanks for the patch! LGTM
 test/LuaJIT-tests/trace/tcall_base.lua | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/LuaJIT-tests/trace/tcall_base.lua b/test/LuaJIT-tests/trace/tcall_base.lua
index 7d8d75e0..65fc118e 100644
--- a/test/LuaJIT-tests/trace/tcall_base.lua
+++ b/test/LuaJIT-tests/trace/tcall_base.lua
@@ -1,11 +1,11 @@
 local r = 0
 local function g()
   r = r + 1
-  for i=1,100 do end
+  for _ = 1, 100 do end
 end
 
 local function f()
-  for j=1,20 do
+  for j = 1, 20 do
     if j > 19 then
       return g() -- Tailcall at base.
       -- Let this link to the already compiled loop in g().
@@ -15,6 +15,6 @@ end
 
 do --- Recording tailcall at base slot.
   g() -- Compile this loop first.
-  for i=1,50 do f() end
+  for _ = 1, 50 do f() end
   assert(r == 51)
 end
--------------UxONeowaoWdbecvPFqS1UZX6--