From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2D16D259B0 for ; Fri, 18 May 2018 13:24:23 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ETdoA7-Yg3hN for ; Fri, 18 May 2018 13:24:23 -0400 (EDT) Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D5FA5259AE for ; Fri, 18 May 2018 13:24:22 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH v6 2/4] sql: remove SQL fields from Table and Column From: "n.pettik" In-Reply-To: <4ede3bde-98d1-cc92-6659-891ef61e0917@tarantool.org> Date: Fri, 18 May 2018 20:24:13 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <8524A570-B5A4-4053-A6AE-FA8D926DA15D@tarantool.org> References: <2cd3d86ce88d5115c5ec12611d40251fcc7968bd.1526403792.git.kshcherbatov@tarantool.org> <4ede3bde-98d1-cc92-6659-891ef61e0917@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov > @@ -146,6 +146,12 @@ sql_expr_free(struct sqlite3 *db, struct Expr = *expr, bool extern_alloc); >=20 > /** > * Create and initialize a new ephemeral SQL Table object. > + * All memory allocation operations except Table object itself > + * are performed in the region. > + * > + * The 'ephemeral' means that this memory is temporal, > + * so the table should be rebuild with sql_table_def_rebuild for = further use. Fit comments in 66 chars. Moreover, I see that you accidentally included changes concerning this comment to the next patch. Lets return it back to this one. > + * > * @param parser SQL Parser object. > * @param name Table to create name. > * @retval NULL on memory allocation error, Parser state changed. > @@ -156,6 +162,11 @@ sql_ephemeral_table_new(struct Parse *parser, = const char *name); >=20 > /** > * Create and initialize a new ephemeral space_def object. > + * All memory allocation operations are performed on the region. > + * > + * The 'ephemeral' means that this memory is temporal, > + * so the table should be rebuild with sql_table_def_rebuild for = further use. Lets don=E2=80=99t repeat the same comment twice. You may refer to it, = if you want. >> I would mention in commit message about the fact that >> now almost within parsing context is allocated on region, >> and at the end of parsing region is truncated. Or, at least, >> in comments to sql_parser_destroy()/sql_parser_create() > @@ -4157,6 +4157,8 @@ table_column_nullable_action(struct Table *tab, = uint32_t column); >=20 > /** > * Initialize a new parser object. > + * A number of service allocations are performed on the region, which = is also Fit comment in 66 chars.