From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 33D1D46970E for ; Sun, 22 Dec 2019 20:59:17 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: <84fcecd3-af3b-8001-ed91-14b07f57e06a@tarantool.org> Date: Sun, 22 Dec 2019 18:59:15 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 0/5] introduce anonymous replicas List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergepetrenko , georgy@tarantool.org Cc: tarantool-patches@dev.tarantool.org Hi! Thanks for the patch, overall it looks cool. It would be cool to have a brief explanations of what was done in the patchset. Sorry, I didn't add my fixes on top of your commits, because I am afraid it may complicate reverting some of them, because you know replication code better than me and I may be wrong somewhere. I will do fixes in case after this review only some extra minor comments will remain. On 15/12/2019 21:56, sergepetrenko wrote: > Serge Petrenko (3): > box: update comment describing join protocol > replication: do not decode replicaset uuid when processing a subscribe > applier: split join processing into two stages > > sergepetrenko (2): > vclock: ignore 0th component in comparisons. > replication: introduce anonymous replica. Seems like you authored the commits from 2 different accounts: sergepetrenko and Serge Petrenko. Please, choose one.