From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5E251499517; Mon, 5 Jun 2023 13:45:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5E251499517 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1685961959; bh=D4YoEeYxGA7GpiIpBYy03OESkSSQWyPylV0N1CDH7k0=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=V2HbJw1QTZ/Pkey3LQkLKIkuTOWydibCnudLM+6hvzezTBF1ETmSO2qsmHBCD42V8 +I0QMObtVzrLdct3XnumT+S//QAcbd7RPEef12n095fi7mH5SmWAyRs3XJqPb+2pEY FlBjqMR9ASUfWsI+SBypSbNyEwSQ9tZerAZNd3SY= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5108A499517 for ; Mon, 5 Jun 2023 13:45:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5108A499517 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1q67iK-00BFih-8P; Mon, 05 Jun 2023 13:45:28 +0300 To: Igor Munkin , Maxim Kokryashkin , Sergey Bronnikov Date: Mon, 5 Jun 2023 13:41:12 +0300 Message-Id: <848c82043f91fcaa4883c711cfa85bf1a1bc9959.1685613304.git.skaplun@tarantool.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD988F25420CCA9469ABF45951B91126D7EE632B243DCB7EEE8182A05F5380850405B055E3674AC86FF3D33C4912C067A45D5267E1DC9414BA01C3FA36E388436EA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71EEA4C46C73542F4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BD378188104BC8BE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81BFE282636A891606377A7B0799A84D0117882F4460429728776938767073520437C869540D2AB0FCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE7532CA1512B81981B2D370F7B14D4BC4D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE36D3A1509E1113711AD7EC71F1DB88427C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CD2DCF9CF1F528DBC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16B156CCFE7AF13BCA4B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A54910507BD1E1EC85290AA7B82D7AB259F7CCC3817C22D084F87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B359C5DF10A05D560A950611B66E3DA6D700B0A020F03D25A0997E3FB2386030E77 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340CB2836B823694498CAD3004187CFCB7D3462EC4EA55F88D1F27028480A6091ED2B9D25CD5791ADB1D7E09C32AA3244CE8A17529AB3EE94D3C69B93B0485D4B551E887DA02A9F7BFED9A463B7D0AAFF65DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbL9S8ysBdXhLPelb+eUiUKUdcLkHr9vF X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769A362B55ADB54669F3D33C4912C067A45BE4EBEF89FC7D6FADEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: [Tarantool-patches] [PATCH v3 luajit 1/6] test: fix setting of {DY}LD_LIBRARY_PATH variables X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" When we set `LUA_TEST_ENV_MORE` variable to be used in the additional env command for run testing if `"` is used to wrap the `LD_LIBRARY_PATH` value the content of this environment variable is literally `"/abs/path1:/abs/path2:...:"`. So, the first entry is treated as the relative path starting with `"`. In that case if we need the library to be loaded via FFI for this particular test, that loading fails with the error "cannot open shared object file", since the path to it is incorrect. This patch removes `"` wrapping for the aforementioned variables. --- test/tarantool-tests/CMakeLists.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt index a428d009..38d6ae49 100644 --- a/test/tarantool-tests/CMakeLists.txt +++ b/test/tarantool-tests/CMakeLists.txt @@ -102,6 +102,11 @@ endif() # loaded modules on MacOS instead of shared libraries as it is # done on Linux and BSD, another environment variable should be # used to guide while searching the extension. +# XXX: Be noticed that we shouldn't use `"` here to wrap +# the variable's content. If we do this, the variable value will +# contain `"` at the beginning and the end, so this `"` at the +# beginning will be treated as the directory for the first entry +# (the last subdirectory added). if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") # XXX: Apple tries their best to "protect their users from # malware". As a result SIP (see the link[1] below) has been @@ -122,9 +127,9 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") # # [1]: https://support.apple.com/en-us/HT204899 # [2]: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html - list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH="${LD_LIBRARY_PATH}") + list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH=${LD_LIBRARY_PATH}) else() - list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH="${LD_LIBRARY_PATH}") + list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH=${LD_LIBRARY_PATH}) endif() # LUA_CPATH and LD_LIBRARY_PATH variables and also TESTLIBS list -- 2.34.1