From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 33C87485700; Thu, 18 May 2023 23:49:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 33C87485700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1684442973; bh=D4YoEeYxGA7GpiIpBYy03OESkSSQWyPylV0N1CDH7k0=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VM+gO5y25ZsdlArJ1x2ZaWRdB577ZKdvFFwES1o0E78OtMSfDMe1m7PHsOhWntKZv 6kcTSOxdmxzgVCIlBzh3Jg8QTZezsQ47qES3ekKcFUNEIzn9pzETY7jeu8U2JlVjcF +69Top4mVPbUTbWd6ggWNpCcqEHh0qxJ4vEKsvQY= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 79B52485700 for ; Thu, 18 May 2023 23:49:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 79B52485700 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1pzkYX-0005wh-Cc; Thu, 18 May 2023 23:49:01 +0300 To: Igor Munkin , Maxim Kokryashkin , Sergey Bronnikov Date: Thu, 18 May 2023 23:44:48 +0300 Message-Id: <848c82043f91fcaa4883c711cfa85bf1a1bc9959.1684442182.git.skaplun@tarantool.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD921E8753A900160F177123CF1EC9E6119EFBC07117266AD44182A05F538085040434BEE91004DBF9E8A0892FD1F78AB0E51703C14529DC3833AB30109B6A694AF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AA1605287C7F04D6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378556F4CD9D953FFE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EA7727402ADF6D63D4D0CBC65DB9F53D117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC406C66621D3021AFA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520437C869540D2AB0F2CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B67393CE827C55B5F775ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5FB7440E97EDBC503DDE4659982D14559609991C996F2CC29F87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B359C5DF10A05D560A950611B66E3DA6D700B0A020F03D25A0997E3FB2386030E77 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34A5112A9AECFE11B14DCB57E16195297176F76393399389E8E3809E479F8D4F661F8C23A6D4FD43801D7E09C32AA3244C1DD13BF0A1ECC790B2BE4EF1D270F64EA8CE788DE683120583B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojXj30btAgf0aWOEyp79dIwg== X-DA7885C5: F8A7104FA0DCF5BA117DE7BC9A9FF824D3AF172CB90260B3F989396BD0ECC9F9262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF541ACC1812D7E319CCBEF9189A1644D6B0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: [Tarantool-patches] [PATCH v2 luajit 1/6] test: fix setting of {DY}LD_LIBRARY_PATH variables X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" When we set `LUA_TEST_ENV_MORE` variable to be used in the additional env command for run testing if `"` is used to wrap the `LD_LIBRARY_PATH` value the content of this environment variable is literally `"/abs/path1:/abs/path2:...:"`. So, the first entry is treated as the relative path starting with `"`. In that case if we need the library to be loaded via FFI for this particular test, that loading fails with the error "cannot open shared object file", since the path to it is incorrect. This patch removes `"` wrapping for the aforementioned variables. --- test/tarantool-tests/CMakeLists.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt index a428d009..38d6ae49 100644 --- a/test/tarantool-tests/CMakeLists.txt +++ b/test/tarantool-tests/CMakeLists.txt @@ -102,6 +102,11 @@ endif() # loaded modules on MacOS instead of shared libraries as it is # done on Linux and BSD, another environment variable should be # used to guide while searching the extension. +# XXX: Be noticed that we shouldn't use `"` here to wrap +# the variable's content. If we do this, the variable value will +# contain `"` at the beginning and the end, so this `"` at the +# beginning will be treated as the directory for the first entry +# (the last subdirectory added). if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") # XXX: Apple tries their best to "protect their users from # malware". As a result SIP (see the link[1] below) has been @@ -122,9 +127,9 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") # # [1]: https://support.apple.com/en-us/HT204899 # [2]: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html - list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH="${LD_LIBRARY_PATH}") + list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH=${LD_LIBRARY_PATH}) else() - list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH="${LD_LIBRARY_PATH}") + list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH=${LD_LIBRARY_PATH}) endif() # LUA_CPATH and LD_LIBRARY_PATH variables and also TESTLIBS list -- 2.34.1