From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alyapunov@tarantool.org>
Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 903DB42F4AD
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 23 Jun 2020 15:32:30 +0300 (MSK)
References: <cover.1586808463.git.korablev@tarantool.org>
 <0bdc1b5e-82b4-2e24-ad06-26587b007742@tarantool.org>
 <20200522024206.GA24698@tarantool.org>
 <9820269f-95a1-4d11-c08f-c2dd2b642740@tarantool.org>
 <20200622202108.GA32744@tarantool.org>
From: Aleksandr Lyapunov <alyapunov@tarantool.org>
Message-ID: <8489bdc4-a128-212b-9da2-f6101cd825a0@tarantool.org>
Date: Tue, 23 Jun 2020 15:32:29 +0300
MIME-Version: 1.0
In-Reply-To: <20200622202108.GA32744@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH 0/2] Validate result of upserts
 squash & skip invalid upserts which can't be applied
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>


>> I bet we should just remove assert here. If mem_stmt have
>> a valid LSN now - it is a valid statement. The first of them must
>> have n_upserts=0, the second - 1 etc, and n_upsert of following
>> prepared statements must continue the sequence.
> What is the point of keeping counting n_upserts for upserts
> which can't be squashed? For sure we can simply remove assertion,
> but then after accumulating more than 128 upserts which can't
> be applied, vy_squash_process won't be called till dump...
>
Why can't? After accumulating more 128 upserts squash process
must be restarted and squash those upserts that became committed.