From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 759F926992 for ; Fri, 29 Jun 2018 10:14:32 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GjLQLbHVRvnS for ; Fri, 29 Jun 2018 10:14:32 -0400 (EDT) Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2A94926971 for ; Fri, 29 Jun 2018 10:14:30 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH v2 3/3] sql: enable multi-engine tests for SQL From: "n.pettik" In-Reply-To: Date: Fri, 29 Jun 2018 17:14:28 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <84788764-363B-483A-8353-5A3FD61B1F7F@tarantool.org> References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov >=20 > +-- SQL Analyze is working correctly only with memtx now. But test-run anyway runs them twice: [003] sql-tap/analyzeC.test.lua memtx [ = pass ] [008] sql-tap/analyze7.test.lua memtx [ = pass ] [002] sql-tap/analyze1.test.lua memtx [ = pass ] [006] sql-tap/analyzeE.test.lua memtx [ = pass ] [001] sql-tap/analyzeF.test.lua vinyl [ = pass ] [007] sql-tap/analyze6.test.lua vinyl [ = pass ] [006] sql-tap/analyzeC.test.lua vinyl [ = pass ] [002] sql-tap/analyze8.test.lua memtx [ = pass ] [006] sql-tap/analyze4.test.lua memtx [ = pass ] [007] sql-tap/analyze4.test.lua vinyl [ = pass ] [004] sql-tap/analyze3.test.lua memtx [ = pass ] [006] sql-tap/analyzeD.test.lua memtx [ = pass ] [007] sql-tap/analyze1.test.lua vinyl [ = pass ] [004] sql-tap/analyze7.test.lua vinyl [ = pass ] [003] sql-tap/analyzeD.test.lua vinyl [ = pass ] [004] sql-tap/analyze6.test.lua memtx [ = pass ] [003] sql-tap/analyzeF.test.lua memtx [ = pass ] [006] sql-tap/analyze8.test.lua vinyl [ = pass ] [002] sql-tap/analyzeE.test.lua vinyl [ = pass ] [007] sql-tap/analyze5.test.lua memtx [ = pass ] [004] sql-tap/analyze3.test.lua vinyl [ = pass ] [001] sql-tap/analyze5.test.lua vinyl [ = pass ] [005] sql-tap/analyze9.test.lua vinyl [ = pass ] [008] sql-tap/analyze9.test.lua memtx [ = pass ] Could we disable them for vinyl somehow and run only once? Some of them take long time to execute. >=20 > diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini > index e259be2..16aaf5a 100644 > --- a/test/sql-tap/suite.ini > +++ b/test/sql-tap/suite.ini > @@ -5,3 +5,4 @@ disabled =3D > reindex.test.lua ; This test is banned in scope of #2174 > lua_libs =3D lua/sqltester.lua ../sql/lua/sql_tokenizer.lua = ../box/lua/identifier.lua > is_parallel =3D True > +config =3D engine.cfg > \ No newline at end of file Lets put newline at the end of file. > diff --git a/test/sql/engine.test.lua b/test/sql/engine.test.lua > new file mode 100644 > index 0000000..2a07c71 > --- /dev/null > +++ b/test/sql/engine.test.lua > @@ -0,0 +1,17 @@ > +env =3D require('test_run') > +test_run =3D env.new() > + > +box.sql.execute("pragma sql_default_engine=3D'vinyl'") > +box.sql.execute("CREATE TABLE t1_vinyl(a primary key,b,c);") > +box.sql.execute("CREATE TABLE t2_vinyl(a primary key,b,c);=E2=80=9D) Please, use types for columns: we are going to introduce static types in SQL and make them mandatory.