From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 87CCC4696C3 for ; Sun, 12 Apr 2020 17:05:21 +0300 (MSK) References: <20200412113423.GA28681@atlas> From: Vladislav Shpilevoy Message-ID: <84069240-b5a4-9e61-09f4-a347fe53d54c@tarantool.org> Date: Sun, 12 Apr 2020 16:05:18 +0200 MIME-Version: 1.0 In-Reply-To: <20200412113423.GA28681@atlas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 00/43] Unhide symbols List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Konstantin Osipov , tarantool-patches@dev.tarantool.org On 12/04/2020 13:34, Konstantin Osipov wrote: > * Vladislav Shpilevoy [20/04/12 14:24]: > > >> The patchset makes Tarantool stop hiding not explicitly exported >> symbols. >> >> It means, all FFI and public C API related symbols are still >> always exported. All the other symbols may be exported, or may be >> not. >> >> That feature was requested solely by Mons. > > :-( > > >> To make the needed symbols visible the hack with function >> addresses was returned back, like it was before >> https://github.com/tarantool/tarantool/commit/4c4c1ccbe422e1420ce0c0b36194fc61bb857ed4, >> but in a more structured form. > > The exports used to be autogenerated. Instead, you introduce > a manually crafted list. It was never autogenerated. We always patched extra/exports file. That makes almost all your comments irrelevant.