From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 34A6324E91 for ; Sun, 8 Sep 2019 08:50:07 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TCSOVG4rMOKL for ; Sun, 8 Sep 2019 08:50:07 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E9F0F24E61 for ; Sun, 8 Sep 2019 08:50:04 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 2/2] wal: drop rows_per_wal option From: Vladislav Shpilevoy References: Message-ID: <8403c1b5-feca-f008-a710-39370f5e9781@tarantool.org> Date: Sun, 8 Sep 2019 14:53:42 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: alexander.turenko@tarantool.org Changed a constant and its comment, as asked by Kostja: diff --git a/src/box/wal.h b/src/box/wal.h index 2ddc008ff..b76b0a41f 100644 --- a/src/box/wal.h +++ b/src/box/wal.h @@ -45,13 +45,11 @@ enum wal_mode { WAL_NONE = 0, WAL_WRITE, WAL_FSYNC, WAL_MODE_MAX }; enum { /** - * Such a value originates from the old setting - * 'rows_per_wal'. By default it was 500000, and its - * value was used to decide how often wal writer needs - * to yield, by formula: (rows_per_wal >> 4) + 1. With - * default rows_per_wal it was equal to this constant. + * Recovery yields once per that number of rows read and + * applied from WAL. It allows not to block the event + * loop for the whole recovery stage. */ - WAL_ROWS_PER_YIELD = 31251, + WAL_ROWS_PER_YIELD = 32000, };