From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 32C1E469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 18 May 2020 15:04:32 +0300 (MSK)
References: <20200512135052.221379-1-gorcunov@gmail.com>
 <20200512135052.221379-3-gorcunov@gmail.com>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <83e8b7bb-2866-7ac1-6c4e-ef25113ff320@tarantool.org>
Date: Mon, 18 May 2020 15:04:29 +0300
MIME-Version: 1.0
In-Reply-To: <20200512135052.221379-3-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/7] box/console: use tabs instead
 of spaces in consolelib
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

LGTM

On 12/05/2020 16:50, Cyrill Gorcunov wrote:
> For some reason we're using spaces here to adjust code.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>   src/box/lua/console.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/src/box/lua/console.c b/src/box/lua/console.c
> index d937d684e..d437ff3fe 100644
> --- a/src/box/lua/console.c
> +++ b/src/box/lua/console.c
> @@ -552,11 +552,11 @@ void
>   tarantool_lua_console_init(struct lua_State *L)
>   {
>   	static const struct luaL_Reg consolelib[] = {
> -		{"load_history",       lbox_console_load_history},
> -		{"save_history",       lbox_console_save_history},
> -		{"add_history",        lbox_console_add_history},
> -		{"completion_handler", lbox_console_completion_handler},
> -		{"format",             lbox_console_format},
> +		{"load_history",	lbox_console_load_history},
> +		{"save_history",	lbox_console_save_history},
> +		{"add_history",		lbox_console_add_history},
> +		{"completion_handler",	lbox_console_completion_handler},
> +		{"format_yaml",		lbox_console_format_yaml},
>   		{NULL, NULL}
>   	};
>   	luaL_register_module(L, "console", consolelib);
>