From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 411CA469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  8 Oct 2020 01:12:31 +0300 (MSK)
References: <cover.1600817803.git.alexander.turenko@tarantool.org>
 <cd326628673cc6f2cbd0262ace543e70ae11433e.1600817803.git.alexander.turenko@tarantool.org>
 <53487cd7-3903-99e1-eb77-aaf24c76f170@tarantool.org>
 <20201007113021.um52i5zfqi4kal3q@tkn_work_nb>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <8388f955-ae70-2fa4-be47-c3240baac83f@tarantool.org>
Date: Thu, 8 Oct 2020 00:12:28 +0200
MIME-Version: 1.0
In-Reply-To: <20201007113021.um52i5zfqi4kal3q@tkn_work_nb>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 08/14] WIP: refactoring: extract
 key_def module API functions
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the answers!

>>> Added libtuple.a to the so called reexport libraries list, because
>>> otherwise the functions from key_def_api compilation unit are not
>>> exported on 1.10 (in the backported patch).
>>>
>>> Part of #5273
>>> ---
>>> diff --git a/src/box/key_def_api.h b/src/box/key_def_api.h
>>> new file mode 100644
>>> index 000000000..5b1c861f5
>>> --- /dev/null
>>> +++ b/src/box/key_def_api.h
>>> @@ -0,0 +1,101 @@
>>> +#ifndef TARANTOOL_BOX_KEY_DEF_API_H_INCLUDED
>>> +#define TARANTOOL_BOX_KEY_DEF_API_H_INCLUDED
>>
>> 2. Lets use '#pragma once'.
> 
>  | Use header guards.
> 
> https://www.tarantool.io/en/doc/latest/dev_guide/c_style_guide/
> 
> Rules are rules.
> 
> You know, I don't like '#pragra once', because it works in non-obvious
> way, had various bugs in the past and may slow down compilation ([1]).
> So I will follow the accepted style.

Then you should use pragma, because they are our rule. I don't believe
you don't remember that discussion. I remember it was assigned to Kirill
to update the docs, since he approved that style change, but it seems he
just didn't.