From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BEFEB469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  2 Jun 2020 10:51:11 +0300 (MSK)
From: Oleg Babin <olegrok@tarantool.org>
References: <20200601222507.560415-1-gorcunov@gmail.com>
 <20200601222507.560415-3-gorcunov@gmail.com>
Message-ID: <836fb7c2-21e1-41ef-bf81-b6294bb4166f@tarantool.org>
Date: Tue, 2 Jun 2020 10:51:10 +0300
MIME-Version: 1.0
In-Reply-To: <20200601222507.560415-3-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v7 02/11] core/say: use
 say_logger_initialized in say_logger_free
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

LGTM

On 02/06/2020 01:24, Cyrill Gorcunov wrote:
> To eliminate opencoded comparision.
> 
> Reviewed-by: Leonid Vasiliev <lvasiliev@tarantool.org>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>   src/lib/core/say.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/core/say.c b/src/lib/core/say.c
> index d8f59fb9b..791011e6f 100644
> --- a/src/lib/core/say.c
> +++ b/src/lib/core/say.c
> @@ -749,7 +749,7 @@ say_logger_init(const char *init_str, int level, int nonblock,
>   void
>   say_logger_free()
>   {
> -	if (log_default == &log_std)
> +	if (say_logger_initialized())
>   		log_destroy(&log_std);
>   }
>   
>