From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 405B4C596BA; Fri, 23 Aug 2024 18:42:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 405B4C596BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724427746; bh=fHZptMtdYcWZRbBx6s9uZW86h82WSnp/bwEar2r0BO0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lSH11knYsmuw6bdFXJS6vJcIDebLPH1yLeGvw1CFJhxyQGbsgbCbnVXriIj4YxBSI /r2DH/P7wzNmQ7q3/BgGX2qUG8abS1Wax588mgNuxMYHDEqL2citSLyUNdvaK9yBMN MVd+0ThKIpF7vcd6P+y/wvzlYl7R1XjWFOwUWiq8= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [95.163.41.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 70A1CC59685 for ; Fri, 23 Aug 2024 18:42:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 70A1CC59685 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1shWQh-0000000Bijr-3K2n; Fri, 23 Aug 2024 18:42:24 +0300 Content-Type: multipart/alternative; boundary="------------LI0ZhK6HTNYsIB63MYrRAI5T" Message-ID: <8334bf9b-5301-41e1-b7cf-eaea901a7502@tarantool.org> Date: Fri, 23 Aug 2024 18:42:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <358fec19-25ee-49c2-a6a8-d40b999a92f5@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9604F665CF1C84C2980712E41772963EBDDF38C41D9EC0CE9182A05F5380850404C228DA9ACA6FE2718FC9B23178D252433594132A326AF8BE3454CA9A01293E402F1026AD89F940D4E6D196D713C17FF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A4C4638C9DDF45FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063727599E9BE65898D58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D870A41CAD47CEE0FA1A578B96928B42ECDB9F5E5362A17E94CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F79006372A3B24BF85B2E607389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F79006375A3BF3EE4266CDCED81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE76937630EBE596648EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3CD42BCEBB57B85E635872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A519686C39ED04EDBB5002B1117B3ED696FC2F5D88BF9C044354BB1175C6E7DD94823CB91A9FED034534781492E4B8EEAD003C2D46C52F18F2BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C264B329661203DAA786DEFBFD864908002E5A6ED21F36528D820B36AEFBEB038214F9A6E97ECDD21D7E09C32AA3244C3ACEC92BA09C5BE27B0DC8E7D22A103A23D697E94FCE4450EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPqZSx9J9Ex0aIiqOxd8rHg== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140C052CF2EFACC7803AE5D5214B3CC02C53AD399438A0457120152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 34/45] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------LI0ZhK6HTNYsIB63MYrRAI5T Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sergey, On 22.08.2024 17:34, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Please consider my answer below. > > On 22.08.24, Sergey Bronnikov wrote: >> Sergey, >> >> On 21.08.2024 11:58, Sergey Kaplun wrote: >>> This patch moves the aforementioned test from the to the >>> directory, includes it in , names the subtests, and adds testing >>> of the error message for all non-tail call cases. >>> >>> Part of tarantool/tarantool#9398 >>> --- >> thanks for the patch! LGTM with a minor comment below. >>> test/LuaJIT-tests/lang/index | 1 + >>> test/LuaJIT-tests/lang/stackov.lua | 48 ++++++++++++++++++++++++++++++ >> Probably filename "stack_overflow.lua" will be better. Feel free to ignore. > I prefer to leave it as is, since it is consistent with the error name > in sources, if you don't insist. Ok, let's leave it as is. LGTM as I said previously. > >>> test/LuaJIT-tests/misc/stackov.lua | 40 ------------------------- >>> 3 files changed, 49 insertions(+), 40 deletions(-) >>> create mode 100644 test/LuaJIT-tests/lang/stackov.lua >>> delete mode 100644 test/LuaJIT-tests/misc/stackov.lua >>> > > --------------LI0ZhK6HTNYsIB63MYrRAI5T Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Sergey,

On 22.08.2024 17:34, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Please consider my answer below.

On 22.08.24, Sergey Bronnikov wrote:

Sergey,

On 21.08.2024 11:58, Sergey Kaplun wrote:

This patch moves the aforementioned test from the <misc> to the <lang/>
directory, includes it in <index>, names the subtests, and adds testing
of the error message for all non-tail call cases.

Part of tarantool/tarantool#9398
---

thanks for the patch! LGTM with a minor comment below.

  test/LuaJIT-tests/lang/index       |  1 +
  test/LuaJIT-tests/lang/stackov.lua | 48 ++++++++++++++++++++++++++++++

Probably filename "stack_overflow.lua" will be better. Feel free to ignore.

I prefer to leave it as is, since it is consistent with the error name
in sources, if you don't insist.
Ok, let's leave it as is. LGTM as I said previously.


  test/LuaJIT-tests/misc/stackov.lua | 40 -------------------------
  3 files changed, 49 insertions(+), 40 deletions(-)
  create mode 100644 test/LuaJIT-tests/lang/stackov.lua
  delete mode 100644 test/LuaJIT-tests/misc/stackov.lua


<snipped>
--------------LI0ZhK6HTNYsIB63MYrRAI5T--