Sergey, On 22.08.2024 17:34, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Please consider my answer below. > > On 22.08.24, Sergey Bronnikov wrote: >> Sergey, >> >> On 21.08.2024 11:58, Sergey Kaplun wrote: >>> This patch moves the aforementioned test from the to the >>> directory, includes it in , names the subtests, and adds testing >>> of the error message for all non-tail call cases. >>> >>> Part of tarantool/tarantool#9398 >>> --- >> thanks for the patch! LGTM with a minor comment below. >>> test/LuaJIT-tests/lang/index | 1 + >>> test/LuaJIT-tests/lang/stackov.lua | 48 ++++++++++++++++++++++++++++++ >> Probably filename "stack_overflow.lua" will be better. Feel free to ignore. > I prefer to leave it as is, since it is consistent with the error name > in sources, if you don't insist. Ok, let's leave it as is. LGTM as I said previously. > >>> test/LuaJIT-tests/misc/stackov.lua | 40 ------------------------- >>> 3 files changed, 49 insertions(+), 40 deletions(-) >>> create mode 100644 test/LuaJIT-tests/lang/stackov.lua >>> delete mode 100644 test/LuaJIT-tests/misc/stackov.lua >>> > >