From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 2/2] info: remove false comments from src/info.h References: <20181204090224.clqmdwibpqpallva@esperanza> From: Vladislav Shpilevoy Message-ID: <82f8dcde-7dec-9509-d499-9bb25d5348de@tarantool.org> Date: Tue, 4 Dec 2018 12:11:09 +0300 MIME-Version: 1.0 In-Reply-To: <20181204090224.clqmdwibpqpallva@esperanza> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: On 04/12/2018 12:02, Vladimir Davydov wrote: > On Tue, Dec 04, 2018 at 12:47:06AM +0300, Vladislav Shpilevoy wrote: >> --- >> src/info.h | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/src/info.h b/src/info.h >> index 0198c31d4..cafa425e9 100644 >> --- a/src/info.h >> +++ b/src/info.h >> @@ -103,7 +103,6 @@ struct info_handler { >> /** >> * Starts a new document and creates root-level associative array. >> * @param info box.info() adapter. >> - * @throws C++ exception on OOM, see info.h comments. >> * @pre must be called once before any other functions. > > These comments are valid - info handler does throw an exception on OOM, > and there's a comment in src/info.h mentioning that. So I dropped this > patch. > Sorry, I though you forgot about it and pushed it by myself. Also, it does not throw C++ exceptions, even on OOM.