From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6077522259
	for <tarantool-patches@freelists.org>; Mon, 24 Dec 2018 09:01:37 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id TaINX5dDqd4H for <tarantool-patches@freelists.org>;
	Mon, 24 Dec 2018 09:01:37 -0500 (EST)
Received: from smtp1.mail.ru (smtp1.mail.ru [94.100.179.111])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C1C6021CF5
	for <tarantool-patches@freelists.org>; Mon, 24 Dec 2018 09:01:36 -0500 (EST)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
Subject: [tarantool-patches] Re: [PATCH v2 1/6] sql: remove unnecessary macros
 from pragma.*
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <5e5daaaeb306feae8caf3af98a3708431c58062e.1544871594.git.imeevma@gmail.com>
Date: Mon, 24 Dec 2018 16:01:33 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <82E2786D-D829-4950-AE7D-6094955EE4D4@tarantool.org>
References: <cover.1544871593.git.imeevma@gmail.com>
 <5e5daaaeb306feae8caf3af98a3708431c58062e.1544871594.git.imeevma@gmail.com>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>

Nit: at the end of commit subject redundant =E2=80=98*=E2=80=99 and dot.

> On 15 Dec 2018, at 13:54, imeevma@tarantool.org wrote:
>=20
> Some of the macros used in pragma.c and pragma.h are obsolete
> because the values they checked were deleted.

They weren=E2=80=99t deleted, they are simply not used.
I guess they still can be enabled, if add appropriate commands
to cmake lists. On the other hand, I doubt that someday we
really may need them.

> Part of #3832

In fact, this commit has nothing in common with mentioned issue.

> -#if !defined(SQLITE_OMIT_FLAG_PRAGMAS)
> 	{ /* zName:     */ "query_only",
> 	 /* ePragTyp:  */ PragTyp_FLAG,
> 	 /* ePragFlg:  */ PragFlg_Result0 | PragFlg_NoColumns1,
> @@ -168,28 +157,23 @@ static const PragmaName aPragmaName[] =3D {
> 	 /* ePragFlg:  */ PragFlg_Result0 | PragFlg_NoColumns1,
> 	 /* ColNames:  */ 0, 0,
> 	 /* iArg:      */ SQLITE_RecTriggers},
> -#endif
> -#if !defined(SQLITE_OMIT_FLAG_PRAGMAS)
> 	{ /* zName:     */ "reverse_unordered_selects",
> 	 /* ePragTyp:  */ PragTyp_FLAG,
> 	 /* ePragFlg:  */ PragFlg_Result0 | PragFlg_NoColumns1,
> 	 /* ColNames:  */ 0, 0,
> 	 /* iArg:      */ SQLITE_ReverseOrder},
> -#endif
> -#if !defined(SQLITE_OMIT_FLAG_PRAGMAS) && =
defined(SQLITE_ENABLE_SELECTTRACE)
> +#if defined(SQLITE_ENABLE_SELECTTRACE)

Why didn=E2=80=99t you remove ENABLE_SELECTTRACE as well?

> @@ -254,8 +231,7 @@ static const PragmaName aPragmaName[] =3D {
> 	 /* ColNames:  */ 0, 0,
> 	 /* iArg:      */ SQLITE_VdbeTrace},
> #endif
> -#endif
> -#if !defined(SQLITE_OMIT_FLAG_PRAGMAS) && =
defined(SQLITE_ENABLE_WHERETRACE)
> +#if defined(SQLITE_ENABLE_WHERETRACE)

The same question.