From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4A05A469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 18 May 2020 18:18:18 +0300 (MSK)
References: <cover.1589240001.git.v.shpilevoy@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <8292d693-88a3-3c6c-a77e-2da51db0d7dc@tarantool.org>
Date: Mon, 18 May 2020 18:18:16 +0300
MIME-Version: 1.0
In-Reply-To: <cover.1589240001.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH msgpuck 0/2] MP_EXT virtual
	serializer
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org


12.05.2020 02:46, Vladislav Shpilevoy пишет:
> The patchset makes MP_EXT serializer for mp_snprint() and
> mp_fprint() functions virtual.
>
> The patch implements one possible solution - return recursion
> instead of mp_stack into the printers, and make external code
> overload both mp_fprint() and mp_snprint(). The most
> straightforward solution.
>
> However it is possible to avoid overloading both mp_fprint() and
> mp_snprint(). Instead, msgpuck could expose just one virtual
> method, which takes an opaque object with method print() having
> signature like snprintf() and fprintf() - format and arguments.
>
> mp_snprint() would create that opaque object's print() method as
> snprintf(). While mp_fprint() would create this object's print()
> method as fprintf(). Drawback of the solution - ton of virtual
> calls, because serializers tend to call print() a lot, on small
> strings like ':', ', ', and so on. On the other hand, this should
> simplify code in Tarantool, especially MP_ERROR serializer, where
> code duplication was so big for mp_snprint_error() and
> mp_fprint_error(), that I invented some kind of C template for it.
>
> With one virtual method, which accepts a virtual object it would
> be just one mp_print_error().
>
> I decided to leave the final decision to a review discussion.
> Should we keep it like it is done now, or make it even more
> virtual like I described above, or probably there are other ideas.
>
> Branch: http://github.com/tarantool/msgpuck/tree/gerold103/mp_print_ext
> Issue: https://github.com/tarantool/tarantool/issues/4719
>
> Vladislav Shpilevoy (2):
>    Return recursion to mp_snprint() and mp_fprint()
>    Make MP_EXT mp_snprint() and mp_fprint() customizable
>
>   msgpuck.c      | 156 ++++++++++++++++++++++++++++++++-----------------
>   msgpuck.h      |  50 ++++++++++++++++
>   test/msgpuck.c |  83 +++++++++++++++++++++++++-
>   3 files changed, 234 insertions(+), 55 deletions(-)


Hi! Thanks for the patchset! LGTM(including patch 1.5/2)

-- 
Serge Petrenko