From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3A1F62BBB7 for ; Mon, 26 Mar 2018 13:24:25 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MF-dNZaClvO9 for ; Mon, 26 Mar 2018 13:24:25 -0400 (EDT) Received: from smtp2.mail.ru (smtp2.mail.ru [94.100.179.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EC4552BBA6 for ; Mon, 26 Mar 2018 13:24:24 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: [tarantool-patches] Re: [PATCH v2 1/1] netbox: show is_nullable and collation fields From: "v.shpilevoy@tarantool.org" In-Reply-To: Date: Mon, 26 Mar 2018 20:24:22 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <82848BBB-2A50-4CAC-852E-E5EE5C8247A3@tarantool.org> References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org See below 2 minor comments. > 26 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2018 =D0=B3., =D0=B2 20:20, Kirill = Shcherbatov =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0= =B0=D0=BB(=D0=B0): >=20 > Fixes #3256 > --- >=20 > Issue: https://github.com/tarantool/tarantool/issues/3256 > Branch: = https://github.com/tarantool/tarantool/compare/gh-3256-net-box-nullable-co= llation-options-output >=20 > src/box/lua/net_box.lua | 6 ++++- > test/box/net.box.result | 65 = +++++++++++++++++++++++++++++++++++++++++++++++ > test/box/net.box.test.lua | 24 +++++++++++++++++ > 3 files changed, 94 insertions(+), 1 deletion(-) >=20 > diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua > index c7541ed..fe45721 100644 > --- a/test/box/net.box.test.lua > +++ b/test/box/net.box.test.lua > @@ -798,3 +798,27 @@ c.space.test.index.test_index ~=3D nil > box.schema.user.revoke('guest','read,write,execute','universe') >=20 > space:drop() > + > + 1. Please, do not put multiple empty lines, when it is not necessary. > +-- > +-- gh-3256 net.box is_nullable and collation options output > +-- > + > +space =3D box.schema.create_space('test') > +box.schema.user.grant('guest','read,write,execute','space', 'test') > +pk =3D space:create_index('pk') > +sk =3D space:create_index('sk', {parts =3D {{2, 'unsigned', = is_nullable =3D true}}}) > +c =3D net:connect(box.cfg.listen) > +c.space.test.index.sk.parts > +c:close() > +space:drop() > + > +space =3D box.schema.create_space('test') > +box.schema.user.grant('guest','read,write,execute','space', 'test') > +box.internal.collation.create('test', 'ICU', 'ru-RU') > +sk =3D space:create_index('sk', { type =3D 'tree', parts =3D {{1, = 'str', collation =3D 'test'}}, unique =3D true }) > +c =3D net:connect(box.cfg.listen) > +c.space.test.index.sk.parts > +c:close() > +box.internal.collation.drop('test') > +space:drop() > \ No newline at end of file 2. Please, add an empty line at the end of the file. > --=20 > 2.7.4 >=20