From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B16942D387
	for <tarantool-patches@freelists.org>; Thu,  5 Apr 2018 07:16:50 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id SNi_KAhhlmZB for <tarantool-patches@freelists.org>;
	Thu,  5 Apr 2018 07:16:50 -0400 (EDT)
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A368B2D376
	for <tarantool-patches@freelists.org>; Thu,  5 Apr 2018 07:16:49 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 1/2] sql: remove obsolete SQLite
 routine
References: <cover.1522769126.git.korablev@tarantool.org>
 <0e28c9181b19643504f335a164f8d098fdab6614.1522769126.git.korablev@tarantool.org>
 <7a18a3e7-9076-087e-df93-dde6955adc70@tarantool.org>
 <A03F3193-620E-469D-B1AA-7C240BA4CF61@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <8234232f-13ed-cc02-b54a-0feb6b2ef4f5@tarantool.org>
Date: Thu, 5 Apr 2018 14:16:45 +0300
MIME-Version: 1.0
In-Reply-To: <A03F3193-620E-469D-B1AA-7C240BA4CF61@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org


>> Same about checking sqlite3HashFind results. And if it is
>> possible with not huge diff, can you please rename sqlite3HashFind to 
>> sql_hash_find ?
>
> Is it worth doing? It is going to disappear soon.
Ok, then lets leave as is.
> @@ -1146,7 +1147,7 @@ analyzeTable(Parse * pParse, Table * pTab, Index 
> * pOnlyIdx)
> int iStatCur;
> assert(pTab != 0);
> -sql_set_multi_write(pParse, 0);
> +sql_set_multi_write(pParse, true);
1. Typo? 0 != true.
> @@ -1769,9 +1769,8 @@ xferOptimization(Parse * pParse,/* Parser context */
> int regData, regTupleid;/* Registers holding data and tupleid */
> struct session *user_session = current_session();
> -if (pSelect == 0) {
> +if (pSelect == 0)
2. == NULL.