From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CE4C6445320 for ; Mon, 6 Jul 2020 15:51:43 +0300 (MSK) From: "Alexander V. Tikhonov" Date: Mon, 6 Jul 2020 15:51:41 +0300 Message-Id: <81870339991bd3f54fc532b631f48d8bf4aa2b57.1594039762.git.avtikhon@tarantool.org> Subject: [Tarantool-patches] [PATCH v1] Block linker flag '--no-undefined' List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Yukhin , Alexander Turenko Cc: tarantool-patches@dev.tarantool.org Found that opensuse adding linker flag '--no-undefined' which produces the fails on building tests. Decided to block this flag due to dynamic libraries will be loaded from tarantool executable and will use symbols from it. So it is completely okay to have unresolved symbols at build time. Relates to tarantool/tarantool#4562 --- Github: https://github.com/tarantool/luajit/tree/avtikhon/gh-4562-suse-block-linker-flag Issue: https://github.com/tarantool/tarantool/issues/4562 test/gh-4427-ffi-sandwich/CMakeLists.txt | 1 + test/lj-flush-on-trace/CMakeLists.txt | 1 + 2 files changed, 2 insertions(+) diff --git a/test/gh-4427-ffi-sandwich/CMakeLists.txt b/test/gh-4427-ffi-sandwich/CMakeLists.txt index 995c6bb..6028381 100644 --- a/test/gh-4427-ffi-sandwich/CMakeLists.txt +++ b/test/gh-4427-ffi-sandwich/CMakeLists.txt @@ -1 +1,2 @@ +string(REPLACE "-Wl,--no-undefined" "" CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}") build_lualib(libsandwich libsandwich.c) diff --git a/test/lj-flush-on-trace/CMakeLists.txt b/test/lj-flush-on-trace/CMakeLists.txt index a90452d..4f2f956 100644 --- a/test/lj-flush-on-trace/CMakeLists.txt +++ b/test/lj-flush-on-trace/CMakeLists.txt @@ -1 +1,2 @@ +string(REPLACE "-Wl,--no-undefined" "" CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}") build_lualib(libflush libflush.c) -- 2.17.1