From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ECCF46EC55; Thu, 26 Aug 2021 09:14:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ECCF46EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1629958498; bh=glTPyCDfh6juoxWjlyqev3+10ULvxzRSPTrHFhVFX4U=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Oh9lCR/+hMlJ3rHn2jL6gYpOxlZWaBs7ZcBSMl0gwuJepFFAeq0yKcRmvrdj9hL/V TvJpCftI9eneAdasvTkMovT+jCJp1xY25PlwLZEHX3isHXknGXCrG9Uc1Zr/cumj34 yiJUZpVCXBi8yCBAHMdpC+MEINXI/GGokpzyvK+4= Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4BB546EC56 for ; Thu, 26 Aug 2021 09:14:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4BB546EC56 Received: by smtp16.mail.ru with esmtpa (envelope-from ) id 1mJ8el-0000Md-FE; Thu, 26 Aug 2021 09:14:31 +0300 To: Vladislav Shpilevoy , imun@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <32b7ac476fec0b675b34d032a61326970491c7cf.1628713520.git.babinoleg@mail.ru> <9bcfb440-ae54-717c-e377-b49f134028f7@tarantool.org> Message-ID: <817688b9-5419-0dea-d92d-74a82a9b8da6@tarantool.org> Date: Thu, 26 Aug 2021 09:14:31 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <9bcfb440-ae54-717c-e377-b49f134028f7@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD906AB4890CDABF0C5CB76CEE71D3E4007182A05F5380850402BEE6B769301FE5371EF569A83D887E665A266286889AC5070E04671A415C8E0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DA26CB0764DFC5B8EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637889C00975665ABF68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D833E869034A1E550517D4C5EF246DE6D9117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4BBDB03A3F2A65D472D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3949686D59A6ADCEAAD7EC71F1DB88427C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637FB177F6A8366F17BEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A56A9F8AEDA1353CA9F529CA7AF66BD9D7B3E1B97BE584CBDDD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753177526CD55AFC11410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3447DF5779098ECEE9EF469B2FC98A7DE55D820C103CEAECA87613C8D096767E2419464CCD4C9A2BA41D7E09C32AA3244C3E02EC355D935A01307E91FF9C677998F522A1CF68F4BE05FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojXSF/Tsl6M2OY6AjQsY+XZg== X-Mailru-Sender: 583F1D7ACE8F49BD1042885CEC987B6B057D329C793125E771EF569A83D887E652685D71546B8E9E7019711D9D5B048E1458020726E2BC9FD5ECBA0B92C0A936CDC7563AA7CEBD287402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 4/4] fiber: allocate on_stop triggers using mempool X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for your review. See my answers below. On 25.08.2021 23:34, Vladislav Shpilevoy wrote: > Thanks for the patch! > > See 4 comments below. > > On 11.08.2021 22:33, Oleg Babin via Tarantool-patches wrote: >> From: Oleg Babin >> >> Previously we use malloc for such purpose however we created >> on_stop triggers only if fiber storage was touched. Currently we >> create on_stop trigger for each lua fiber. So it seems reasonable >> to use mempool for such frequent allocations/deallocations. > 1. Does it give any perf win? This commit specifically. Seems like an > overkill. A trigger allocation might happen only once per fiber's > lifetime, and the fiber's creation is supposed to be much longer than > the trigger's malloc. The commit probably gives a tiny fraction of > percent improvement or does not change anything. Do you have results? It's a good question. I thought thank mempool should be faster than malloc. We can easily drop this commit. I had some doubts about it. Benchmark is following: ``` for _ = 1, 10 do     local start = clock.time()     for _ = 1, 1e5 do         fiber.new(function() end)     end     fiber.yield()     print('fiber.new()', clock.time() - start) end ``` Current result on my machine: ``` fiber.new()    1.7790501117706 fiber.new()    0.23458814620972 fiber.new()    0.2239830493927 fiber.new()    0.25585198402405 fiber.new()    0.26314878463745 fiber.new()    0.17044496536255 fiber.new()    0.23963904380798 fiber.new()    0.2929859161377 fiber.new()    0.16769504547119 fiber.new()    0.26060795783997 ``` Previous commit: ``` fiber.new()    1.7500579357147 fiber.new()    0.24660110473633 fiber.new()    0.23380303382874 fiber.new()    0.28128218650818 fiber.new()    0.25019407272339 fiber.new()    0.23627710342407 fiber.new()    0.29107189178467 fiber.new()    0.19264888763428 fiber.new()    0.27617883682251 fiber.new()    0.25651788711548 ``` master: ``` fiber.new()    1.6132490634918 fiber.new()    0.23563098907471 fiber.new()    0.23894000053406 fiber.new()    0.25919413566589 fiber.new()    0.29895401000977 fiber.new()    0.24670886993408 fiber.new()    0.26245188713074 fiber.new()    0.21903514862061 fiber.new()    0.19983816146851 fiber.new()    0.23553991317749 ``` A bit modified test with fiber.new -> fiber.create olegrok/fiber-ref HEAD: ``` fiber.create()    0.14023184776306 fiber.create()    0.13392496109009 fiber.create()    0.13862681388855 fiber.create()    0.13287806510925 fiber.create()    0.14014101028442 fiber.create()    0.15336418151855 fiber.create()    0.13403511047363 fiber.create()    0.12675404548645 fiber.create()    0.13705611228943 fiber.create()    0.13896298408508 ``` olegrok/fiber-ref HEAD~1: ``` fiber.create()    0.13091707229614 fiber.create()    0.12622594833374 fiber.create()    0.13849806785583 fiber.create()    0.13334107398987 fiber.create()    0.12660312652588 fiber.create()    0.13159799575806 fiber.create()    0.12833094596863 fiber.create()    0.1359851360321 fiber.create()    0.1327109336853 fiber.create()    0.12926387786865 ``` master: ``` fiber.create()    0.17535996437073 fiber.create()    0.15730094909668 fiber.create()    0.15560913085938 fiber.create()    0.15467691421509 fiber.create()    0.15472817420959 fiber.create()    0.17342209815979 fiber.create()    0.15398406982422 fiber.create()    0.16387009620667 fiber.create()    0.16766691207886 fiber.create()    0.17136907577515 ``` >> diff --git a/src/lua/fiber.c b/src/lua/fiber.c >> index 268ddf9cc..f7c0ca63f 100644 >> --- a/src/lua/fiber.c >> +++ b/src/lua/fiber.c >> @@ -36,10 +36,19 @@ >> #include "backtrace.h" >> #include "tt_static.h" >> >> +#include > 2. Please, use "" for non-system headers. Fixed >> #include >> #include >> #include >> >> @@ -122,12 +131,13 @@ lbox_pushfiber(struct lua_State *L, struct fiber *f) >> { >> int ref = f->storage.lua.ref; >> if (ref <= 0) { >> - struct trigger *t = (struct trigger *)malloc(sizeof(*t)); >> + struct trigger *t = mempool_alloc(&on_stop_triggers_pool);; >> if (t == NULL) { >> diag_set(OutOfMemory, sizeof(*t), "malloc", "t"); >> luaT_error(L); >> } >> - trigger_create(t, lbox_fiber_on_stop, NULL, (trigger_f0) free); >> + trigger_create(t, lbox_fiber_on_stop, NULL, >> + on_stop_trigger_free); > 3. Misalignment. Fixed >> trigger_add(&f->on_stop, t); >> >> uint64_t fid = f->fid; >> @@ -921,6 +931,9 @@ static const struct luaL_Reg fiberlib[] = { >> void >> tarantool_lua_fiber_init(struct lua_State *L) >> { >> + mempool_create(&on_stop_triggers_pool, &cord()->slabc, >> + sizeof(struct trigger)); > 4. Ditto. Fixed >> + >> luaL_register_module(L, fiberlib_name, fiberlib); >> lua_pop(L, 1); >> luaL_register_type(L, fiberlib_name, lbox_fiber_meta); >>