From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH 0/4] Outdate disconnected session References: <20181207174137.GF840@chai> From: Vladislav Shpilevoy Message-ID: <815ffab7-8716-36f7-8cc7-6c49359de0d1@tarantool.org> Date: Tue, 11 Dec 2018 19:13:50 +0300 MIME-Version: 1.0 In-Reply-To: <20181207174137.GF840@chai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: tarantool-patches@freelists.org, Konstantin Osipov Cc: vdavydov.dev@gmail.com List-ID: On 07/12/2018 20:41, Konstantin Osipov wrote: > * Vladislav Shpilevoy [18/12/07 18:48]: >> Once a connection is closed, a long-running user request can not >> learn about this occasion. Even box.sesion.push() still works and >> on_disconnect triggers are not run. >> >> This patch makes things simpler: >> >> * disconnected session is marked as dead. So a user can determine >> if a connection is closed by looking at session type == 'dead', >> or checking for errors from box.session.push(); >> >> * on_disconnect triggers are run right after disconnect. Even if >> there are some active requests. > > I missed two comments: > > - please a docbot request to one of your changeset comments > - please push both into 2.1 and 1.10, use cherry-picking according to > the new rules. > Doc: https://github.com/tarantool/doc/issues/682 First two commits are cherry-picked to 2.1 and 1.10.