From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B9A39469710 for ; Fri, 29 May 2020 15:15:53 +0300 (MSK) References: <266e9768-27ea-e924-e562-846e74df7760@tarantool.org> <20200529115154.GA144179@atlas> From: Serge Petrenko Message-ID: <8144a701-bd4a-8ec5-604e-0f3106a3b373@tarantool.org> Date: Fri, 29 May 2020 15:15:52 +0300 MIME-Version: 1.0 In-Reply-To: <20200529115154.GA144179@atlas> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [Tarantool-patches] [PATCH v2 2/2] wal: reorder tx rows so that a tx ends on a global row List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Konstantin Osipov Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy 29.05.2020 14:51, Konstantin Osipov пишет: > * Serge Petrenko [20/05/29 14:44]: >> I understand this is a crutch, but it's the best solution I could come >> up with.  Appending dummy  NOPs will increase instance LSN by one, >> which  also looks  ugly. The correct solution is, indeed, to collect  a tx >> in relay and mangle with it in any means  we need before sending, however, >> I faced some problems with this approach. See more in v1 of this patchset >> (letter [PATCH 2/2] replication: make relay send txs in batches). >> > What were the issues changing xstream api apart from never trying? No issues, it's just a big change. At least it looks like there're no issues until I try the approach. > > -- Serge Petrenko