From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 339E1258B5 for ; Tue, 30 Jul 2019 15:50:17 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fQx-0G2937WO for ; Tue, 30 Jul 2019 15:50:17 -0400 (EDT) Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E788625734 for ; Tue, 30 Jul 2019 15:50:16 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 5/5] sql: introduce VARBINARY column type From: Vladislav Shpilevoy References: <49a188eb-dafe-44e7-a0fd-e9244b68e721@tarantool.org> <1293710C-85CC-4F5A-A7CF-4677D901DCE9@tarantool.org> <24a34647-0d0c-7950-b92e-6c8bf3f16d92@tarantool.org> <63A0BD0D-69A9-4CD6-942B-EB9CDDDB21F3@tarantool.org> Message-ID: <80b10469-4c03-f138-fec7-b7a31857cfb8@tarantool.org> Date: Tue, 30 Jul 2019 21:52:23 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "n.pettik" , tarantool-patches@freelists.org, Kirill Yukhin Oh, but wait. Travis is fully red: https://travis-ci.org/tarantool/tarantool/builds/565497371?utm_source=github_status&utm_medium=notification Looks like you forgot to update plan in sql-tap/func.test.lua. On 30/07/2019 21:41, Vladislav Shpilevoy wrote: > Hi! Thanks for the fixes! > > LGTM. > >>>>> 3. BLOB keyword is reserved, but also it is used in parse.y:980. >>>>> Should not it be deleted from all the rules, and be just >>>>> reserved? >>>> >>>> It’s rule for declaring blob (aka binary string) literals. >>>> I can rename it, but TBO it looks OK to me. >>> >>> Could you please provide an example, how to use BLOB keyword to >>> declare a literal? I can't find any test, using BLOB in a query >>> string for anything. >> >> I meant that it’s not the rule that allows BLOB keyword but >> the rule to process X’…’ literals. When string is processed by >> lexer (tokenize.c) its token type is assigned to TK_BLOB. > > Ahh, I got it now. BLOB(X) is not a 'BLOB' keyword, it is rather > like a rule 'BLOB := x...'. Then of course it is ok, nothing to > do here. >