From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EECC621B74
	for <tarantool-patches@freelists.org>; Mon, 28 May 2018 07:19:15 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id d7nAuAMqLqnT for <tarantool-patches@freelists.org>;
	Mon, 28 May 2018 07:19:15 -0400 (EDT)
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id ACC2621AEC
	for <tarantool-patches@freelists.org>; Mon, 28 May 2018 07:19:15 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v7 6/7] sql: export funcs defined
 on Expr, ExprList to sql.h
References: <cover.1527084286.git.kshcherbatov@tarantool.org>
 <26d7bf8070e9e573eb61897c34bf027a52eb8d66.1527084287.git.kshcherbatov@tarantool.org>
 <c92e26a5-08d5-a7e2-3532-5789c264591c@tarantool.org>
 <e44c0bc9-16df-24b1-1f4b-8b47551d4a5a@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <809edd89-13dc-3039-d8e0-964a202bc8f6@tarantool.org>
Date: Mon, 28 May 2018 14:19:12 +0300
MIME-Version: 1.0
In-Reply-To: <e44c0bc9-16df-24b1-1f4b-8b47551d4a5a@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>, tarantool-patches@freelists.org

Thanks for the fixes! See my 3 comments below.

On 25/05/2018 14:53, Kirill Shcherbatov wrote:
>> 1. Please, do not put extra white space after *.
>> 2. Invalid indentation.
>> 3. No pParse.
>> 4. Wrong indentation.
>> 5. Same.
>> 6. Please, consider this diff:

1. Please, do not decontextualize my comments. It is hard
to restore for which code they were intended.

> 
> diff --git a/src/box/sql.h b/src/box/sql.h
> index ec4f298..2a87d14 100644
> --- a/src/box/sql.h
> +++ b/src/box/sql.h
> @@ -190,7 +190,7 @@ sql_table_def_rebuild(struct sqlite3 *db, struct Table *table);
>    * @retval not NULL on success.
>    */
>   struct ExprList *
> -sql_expr_list_dup(struct sqlite3 * db, struct ExprList * p, int flags);
> +sql_expr_list_dup(struct sqlite3 *db, struct ExprList * p, int flags);

> 1. Please, do not put extra white space after *.

2. Still not fixed.

3. Why did you ignore part of comment 7 from the previous review?