From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 09A12445320
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 27 Jul 2020 23:40:48 +0300 (MSK)
References: <20200727140650.447750-1-gorcunov@gmail.com>
 <20200727140650.447750-3-gorcunov@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <806a1209-6838-778a-43ca-fce81d32ae71@tarantool.org>
Date: Mon, 27 Jul 2020 22:40:47 +0200
MIME-Version: 1.0
In-Reply-To: <20200727140650.447750-3-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 2/6] journal: bind asynchronous
 write completion to an entry
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

Hi! Thanks for the patch!

> diff --git a/src/box/journal.h b/src/box/journal.h
> index 9049a2ce0..759eea1da 100644
> --- a/src/box/journal.h
> +++ b/src/box/journal.h
> @@ -39,8 +39,11 @@
>  extern "C" {
>  #endif /* defined(__cplusplus) */
>  
> +struct journal_entry;

1. You removed this declaration in the previous commit. I guess you
don't need the latter now.

>  struct xrow_header;
>  
> +typedef void (*journal_write_async_cb_t)(struct journal_entry *entry);

2. Better replace _cb_t with _f. Or with just _t. Look at key_def.h and
xrow_update_field.h for examples.

> +
>  /**
>   * An entry for an abstract journal.