From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 165CBA4E117; Wed, 13 Mar 2024 12:18:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 165CBA4E117 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1710321511; bh=e8We7DaF5Qn1DXzlxaHyZ+79MzxFz/C9uh6eCaQouxk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sjOCCgLMt6VoS93rykgz7oxb8ZCJTPwChN2IStgsXKXEV8UbyY4KcfMJvQ8Umuuo9 QVOb7kjnYNmXObOrMJBK+be73dvb7n8OMgy7Ol3F3aFsvskDhvqLu3F0BCIA7RgBXM 2j9Bnj81CvrItxEiA6kr9NReR96SqI18g8Qt3vJg= Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [95.163.41.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 50F8FA4E115 for ; Wed, 13 Mar 2024 12:18:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 50F8FA4E115 Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1rkKkn-00000004CVB-04rA; Wed, 13 Mar 2024 12:18:29 +0300 Date: Wed, 13 Mar 2024 12:18:28 +0300 To: Sergey Kaplun Message-ID: <7iupy2dlirwowbaprhoinart6h4lz5mihewccdrfcpc2snoeqa@7uf7mltv47b5> References: <20240311200455.25451-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD93B4404EFBC5FECACE5C610B1725ED3C661FD8B55A48E2EE5182A05F5380850404C228DA9ACA6FE274389DA96B0BC0504D4FF92D56319F1979ABFB026411A5D76A99ACAF4C82F3FEB93B27CBAA3F87F55 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F6EE1C40B2E8BE15EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637A431CDDF496E6E598638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88CCB250176384D73DD1C97D86F859C5F05BA09325BCB6EDBCC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D88302FCEF25BFAB3454AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3E06F720CA742837ABA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C39472471D10B198B935872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5E2FEF3230B04B4CB5002B1117B3ED6969E2474DD080E08B4B48B7A7F94616420823CB91A9FED034534781492E4B8EEAD5DF1C2DF01CE7211BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFD9246032A66E04AE4EECE56AFCC787F50CBB2110A8F76C8B87B9C5362ED56A4E0FDE0425728830097C77D8D956826D3347C2FA6557E63D4D57D77C8487F0B0E65516CEBD9A37BF20C226CC413062362A913E6812662D5F2A54F6898A6FDCBDC72A617DFBE5FEC2C6383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtv/CB9kl0S1yqNl1HrsL3Q== X-Mailru-Sender: 7940E2A4EB16C9976F80DCDCD59EC2274DC0D39F55B4742ED4FF92D56319F1979ABFB026411A5D76E2527C969975515CFF9FCECFB8D89CB6C77752E0C033A69E235A20A81F3B0E39AB3C5F247CB2F7F93A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v5] ci: extend tarantool integration testing X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: Maksim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed, branch is force-pushed. On Wed, Mar 13, 2024 at 10:18:02AM +0300, Sergey Kaplun wrote: > Hi, Max! > Patch LGTM, except a few nits regarding the commit message and > comments. > > Also, may you please provide two separate patches regarding backporting > to the tarantool/release/3.0 and tarantool/release/2.11 branches? > > On 11.03.24, Maksim Kokryashkin wrote: > > From: Maxim Kokryashkin > > > > This patch makes use of reusable workflows from the > > Tarantool repository, so now LuaJIT CI tests integration > > in all relevant workflows. > > > > Also, this patch disables MacOS testing for Tarantool > > integration since those runs were made nightly in the > > Tarantool repo. > > > > As noted in the documentation [1], it is impossible for a single > > workflow call tree to include more than 20 workflows. To > > overcome this limitation, workflows are started in a bunch of > > separate files. This makes it impossible to depend on LuaJIT-only > > jobs for integration workflows such as `tarantool-ecosystem.yml` > > or `tarantool-exotic.yml` since it is impossible to make > > Nit: I suppose it should be " or > ". > > > cross-dependencies between workflow files. Changed this part to the following: | As noted in the documentation [1], it is impossible for a single | workflow call tree to include more than 20 workflows. To overcome | this limitation, workflows are started in a bunch of separate | files. This makes it impossible to depend on LuaJIT-only jobs for | integration workflows such as or | since it is impossible to | make cross-dependencies between workflow files. > > > > > > > --- > > > > Changes in v5: > > - Added secrets section for integration-tarantool-ecosystem.yml to > > resolve the issue with etcd-client integration. > > > > Branch: https://github.com/tarantool/luajit/tree/fckxorg/integration-testing > > > > .../integration-tarantool-ecosystem.yml | 41 ++++++ > > .github/workflows/integration-tarantool.yml | 118 ++++++++++++++++++ > > .github/workflows/testing.yml | 9 ++ > > 3 files changed, 168 insertions(+) > > create mode 100644 .github/workflows/integration-tarantool-ecosystem.yml > > create mode 100644 .github/workflows/integration-tarantool.yml > > > > diff --git a/.github/workflows/integration-tarantool-ecosystem.yml b/.github/workflows/integration-tarantool-ecosystem.yml > > new file mode 100644 > > index 00000000..ccafd601 > > --- /dev/null > > +++ b/.github/workflows/integration-tarantool-ecosystem.yml > > > > > diff --git a/.github/workflows/integration-tarantool.yml b/.github/workflows/integration-tarantool.yml > > new file mode 100644 > > index 00000000..cf5c7fb5 > > --- /dev/null > > +++ b/.github/workflows/integration-tarantool.yml > > > > > diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml > > index cb4ba57b..1581c8fc 100644 > > --- a/.github/workflows/testing.yml > > +++ b/.github/workflows/testing.yml > > @@ -1,3 +1,11 @@ > > +# XXX: A single call tree for reusable workflows can't exceed the > > +# total of 20 workflows, as stated in the documentation [1]. > > +# Some other jobs are started in separate workflow files to > > +# overcome the limitation. The jobs are Tarantool ecosystem > > +# integration testing (tarantool-ecosystem.yml) and exotic > > +# Tarantool builds (tarantool-exotic.yml). > > Nit: I suppose it should be "integration testing of Tarantool > and its ecosystem > ". Fixed. Here is the diff: === diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 1581c8fc..59761963 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -1,9 +1,9 @@ # XXX: A single call tree for reusable workflows can't exceed the # total of 20 workflows, as stated in the documentation [1]. # Some other jobs are started in separate workflow files to -# overcome the limitation. The jobs are Tarantool ecosystem -# integration testing (tarantool-ecosystem.yml) and exotic -# Tarantool builds (tarantool-exotic.yml). +# overcome the limitation. The jobs are integration testing of +# Tarantool and its ecosystem +# . # # [1]: https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations name: Testing === > > > +# > > +# [1]: https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations > > name: Testing > > > > on: > > @@ -108,6 +116,7 @@ jobs: > > > > > > > -- > Best regards, > Sergey Kaplun