From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B62524C885; Tue, 12 Jan 2021 16:59:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B62524C885 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610459952; bh=nmmEUlOTwD6aSIilb7QsdT6oQXtjOta9e/7d3t9aldc=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=t1d7kdk7mYQkqQHIhiLHv2Oq/yfSrajYVPvqLTqI/bX/YgPIPYbfi9xNkUjTk0bX8 cKhcQNL7Hz+HhHiHo6E5QYsOXPbUwC1+/bKWmlT28Z5XKlK9FEbAa1QqiiDwjpiG2W Qmz1a1SJ2jtAjZ9XHtcHWMjiNf++fwo1l6pkeyds= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C83814C885 for ; Tue, 12 Jan 2021 16:59:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C83814C885 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1kzKCT-0001dD-LH; Tue, 12 Jan 2021 16:59:09 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, lvasiliev@tarantool.org References: <4f8d3525-ad8d-5c2a-429d-b87dc8ceb443@tarantool.org> Message-ID: <7fd3e42f-047b-e404-f481-689eb73acb8b@tarantool.org> Date: Tue, 12 Jan 2021 16:59:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <4f8d3525-ad8d-5c2a-429d-b87dc8ceb443@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CD3BE40D5FE7B3134676ED03235248932300894C459B0CD1B9101435C6C6635948101A856C361B8B2BAE39FB7B685260B57A8D2FC48B25BB6B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79961E86438F5BDAEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F757A79C3007ACA28638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC8876ADC81DCE7FEB24C0864CF6AB1878F08A0EC421569714389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C08794E14F7ADDB10D8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D082881546D93491CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FCD138030A6575E01775ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4937D44B9357DF42DBB837C4FEFBD186071C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A56760A563C4EF2C06E7793BC88B5A55B5E4018A531F9BFD39D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347130F804358653A6A8DE53F4BE262BBEE4DA0BEEAB37C2943062E036A7D1D342C48BA4A36383350D1D7E09C32AA3244C1DD5C81A8D48375C26C55E62A2FD52FC3A92A9747B6CC886FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojKc4NKhtl7uHrhMikstjKfw== X-Mailru-Sender: 689FA8AB762F73937240DDB2502DDB700BE65A254C15864274105CAF693DD079DD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v7 3/3] luacheck: fix warnings in test/box-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for review! On 11.01.2021 20:52, Vladislav Shpilevoy wrote: > Thanks for the patch! > >> diff --git a/.luacheckrc b/.luacheckrc >> index 52625bb35..b7f9abb45 100644 >> --- a/.luacheckrc >> +++ b/.luacheckrc >> @@ -157,3 +156,23 @@ files["test/box/lua/fifo.lua"] = { >> files["test/box/lua/identifier.lua"] = { >> globals = {"run_test"} >> } >> +files["test/box-tap/session.test.lua"] = { >> + globals = { >> + "active_connections", > This can be declared 'local'. and with removed a single suppression in .luacheckrc we have got another warnings, that should be suppressed too (inline or in luacheckrc): Checking test/box-tap/session.test.lua            4 warnings     test/box-tap/session.test.lua:73:22: setting non-standard global variable active_connections     test/box-tap/session.test.lua:73:43: accessing undefined variable active_connections     test/box-tap/session.test.lua:74:22: setting non-standard global variable active_connections     test/box-tap/session.test.lua:74:43: accessing undefined variable active_connections I think it is better to keep it as is. > > ==================== > @@ -70,6 +70,7 @@ session.on_disconnect(nil, fail) > > -- check how connect/disconnect triggers work > local peer_name = "peer_name" > +local active_connections = 0 > local function inc() active_connections = active_connections + 1 end > local function dec() active_connections = active_connections - 1 end > local function peer() peer_name = box.session.peer() end > @@ -77,7 +78,6 @@ local net = { box = require('net.box') } > test:is(type(session.on_connect(inc)), "function", "type of trigger inc on_connect") > test:is(type(session.on_disconnect(dec)), "function", "type of trigger dec on_disconnect") > test:is(type(session.on_disconnect(peer)), "function", "type of trigger peer on_disconnect") > -active_connections = 0 > local c = net.box.connect(HOST, PORT) > ====================